Rework note and example in definition of "image of text"#5013
Open
patrickhlauke wants to merge 1 commit intomainfrom
Open
Rework note and example in definition of "image of text"#5013patrickhlauke wants to merge 1 commit intomainfrom
patrickhlauke wants to merge 1 commit intomainfrom
Conversation
patrickhlauke
force-pushed
the
patrickhlauke-images-of-text-definition
branch
from
5932eea to
74a7a14
Compare
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
patrickhlauke
added
Normative
ErratumRaised
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The note is confusing (see #5012), as it appears to exclude important text in combination with other visual elements within the same image, which is not the case. The example is confusing because the context here is unclear - if the main important aspect of the photograph is to show the portrait of a person, and they happen to wear a nametag...then that nametag may well be incidental...unless the whole point of the photo was to in fact show/illustrate the person's name by including the nametag? In any case, this example - particularly coming after that note currently, adds to the confusion. If the note was intended to set up the idea of text being incidental, this should be reworded. And if the example was in reference to the *note*, it should be part of the note.
patrickhlauke
force-pushed
the
patrickhlauke-images-of-text-definition
branch
from
74a7a14 to
01c2a72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The note is confusing (see #5012), as it appears to exclude important text in combination with other visual elements within the same image, which is not the case (though this point, oddly, appears to be in contention?).
The example is confusing because the context here is unclear - if the main important aspect of the photograph is to show the portrait of a person, and they happen to wear a nametag...then that nametag may well be incidental...unless the whole point of the photo was to in fact show/illustrate the person's name by including the nametag? In any case, this example - particularly coming after that note currently, adds to the confusion.
If the note was intended to set up the idea of text being incidental, this should be reworded. And if the example was in reference to the note, it should be part of the note.
This PR rewords the note, and grafts the example (with more explanation/context) directly into the note