[INS-403] Support Custom endpoint config in hashicorpvaultauth Detector#4825
Open
MuneebUllahKhan222 wants to merge 3 commits intotrufflesecurity:mainfrom
Open
[INS-403] Support Custom endpoint config in hashicorpvaultauth Detector#4825MuneebUllahKhan222 wants to merge 3 commits intotrufflesecurity:mainfrom
MuneebUllahKhan222 wants to merge 3 commits intotrufflesecurity:mainfrom
Conversation
rosecodym
approved these changes
Mar 19, 2026
shahzadhaider1
approved these changes
Mar 19, 2026
| if endpoint != vaultUrl { | ||
| t.Fatalf("expected endpoint %s, got %s", vaultUrl, endpoint) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This loop will always run only one time. Also, do you think this loop provides value? because the cmp.Diff at the end is sufficient as it does the same job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR enabled custom endpoint configuration for the existing hashicorpvaultauth detector.
It enables custom endpoint configuration by making the detector comply to
detectors.EndpointCustomizerinterface and updating to default client todetectors.DetectorHttpClientWithNoLocalAddressesto avoid potential security risks like ssrf attacks.This PR also updates the existing test to make sure that the test work fine with the new changes and also introduces a new integration test to emulate custom endpoint configuration.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Adds configurable verification endpoints and changes the default HTTP client to block local addresses, which can affect verification behavior and networking edge cases (e.g., endpoint selection and SSRF protections).
Overview
Enables custom endpoint configuration for the
hashicorpvaultauthdetector by embeddingdetectors.EndpointSetter(implementingdetectors.EndpointCustomizer) and routing verification throughs.Endpoints(...)instead of only URLs found in scanned data.Switches the detector’s default HTTP client to
detectors.DetectorHttpClientWithNoLocalAddressesand adjusts detection logic to require onlyrole_id+secret_id(vault URL can now come from configured/cloud endpoints). Tests are updated to enable endpoint selection, add an integration test forSetConfiguredEndpoints, and update the engine test allowlist for detectors without cloud endpoints.Written by Cursor Bugbot for commit fc7a9df. This will update automatically on new commits. Configure here.