Skip to content

[INS-402] Support custom endpoint configuration in Jira detectors#4818

Open
mustansir14 wants to merge 3 commits intotrufflesecurity:mainfrom
mustansir14:INS-402-Support-custom-verification-endpoints-in-the-Jira-detector
Open

[INS-402] Support custom endpoint configuration in Jira detectors#4818
mustansir14 wants to merge 3 commits intotrufflesecurity:mainfrom
mustansir14:INS-402-Support-custom-verification-endpoints-in-the-Jira-detector

Conversation

@mustansir14
Copy link
Contributor

@mustansir14 mustansir14 commented Mar 17, 2026

Description:

This PR adds support for custom endpoint configuration in the Jira V1 and V2 detectors by implementing the detectors.EndpointCustomizer and detectors.CloudProvider interfaces.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Note

Medium Risk
Changes how Jira detectors choose domains for RawV2/verification by introducing configurable/cloud/found endpoint selection, which can alter detection/verification behavior and result counts. Risk is limited to Jira token scanning logic and is covered by expanded tests.

Overview
Jira token detectors (v1 and v2) now support endpoint customization by embedding EndpointSetter and implementing EndpointCustomizer/CloudProvider, including a default CloudEndpoint() of api.atlassian.com.

FromData no longer unconditionally falls back to api.atlassian.com when no domain is found; instead it builds the candidate domain set from found domains plus any configured endpoints and optional cloud endpoint, normalizing entries by stripping https:// and trailing /.

Tests were updated/expanded to exercise UseFoundEndpoints, UseCloudEndpoint, and configured endpoint combinations for both v1 and v2 (including integration tests enabling found endpoints).

Written by Cursor Bugbot for commit 6947b2a. This will update automatically on new commits. Configure here.

@mustansir14 mustansir14 requested a review from a team March 17, 2026 09:27
@mustansir14 mustansir14 requested a review from a team as a code owner March 17, 2026 09:27
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant