[INS-402] Support custom endpoint configuration in Jira detectors#4818
Open
mustansir14 wants to merge 3 commits intotrufflesecurity:mainfrom
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
This PR adds support for custom endpoint configuration in the Jira V1 and V2 detectors by implementing the
detectors.EndpointCustomizeranddetectors.CloudProviderinterfaces.Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Changes how Jira detectors choose domains for
RawV2/verification by introducing configurable/cloud/found endpoint selection, which can alter detection/verification behavior and result counts. Risk is limited to Jira token scanning logic and is covered by expanded tests.Overview
Jira token detectors (v1 and v2) now support endpoint customization by embedding
EndpointSetterand implementingEndpointCustomizer/CloudProvider, including a defaultCloudEndpoint()ofapi.atlassian.com.FromDatano longer unconditionally falls back toapi.atlassian.comwhen no domain is found; instead it builds the candidate domain set from found domains plus any configured endpoints and optional cloud endpoint, normalizing entries by strippinghttps://and trailing/.Tests were updated/expanded to exercise
UseFoundEndpoints,UseCloudEndpoint, and configured endpoint combinations for both v1 and v2 (including integration tests enabling found endpoints).Written by Cursor Bugbot for commit 6947b2a. This will update automatically on new commits. Configure here.