fix: cap onchain send amount to balance#870
Merged
piotr-iohk merged 1 commit intomasterfrom Mar 26, 2026
Merged
Conversation
Made-with: Cursor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ovitrif
approved these changes
Mar 26, 2026
Collaborator
ovitrif
left a comment
There was a problem hiding this comment.
tAck
LGTM
Note that in order to get this to the level of polishing we had in the RN app, we should also prevent entering a higher amount than the max while using the numpad.
IIRC RN bitkit also had a toast or just red numbers while typing 🤷🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #611
This PR caps the on-chain send amount to the available balance, disabling the Continue button when the entered amount exceeds spendable sats.
Description
The
validateAmountfunction inAppViewModelonly checked that the on-chain amount was above dust limit — it never compared againstmaxSendOnchainSats. This allowed users to proceed with amounts exceeding their balance. Lightning already had this check in place.The fix adds
amount <= maxSendOnchainSatsto the on-chain validation branch, matching the Lightning behavior.Preview
Screen.Recording.2026-03-26.at.15.31.44.mov
QA Notes
E2E test coverage: synonymdev/bitkit-e2e-tests#137
Made with Cursor