Add ability to send posix/ansi signals in SshCommand#1777
Open
Levi--G wants to merge 1 commit intosshnet:developfrom
Open
Add ability to send posix/ansi signals in SshCommand#1777Levi--G wants to merge 1 commit intosshnet:developfrom
Levi--G wants to merge 1 commit intosshnet:developfrom
Conversation
Levi--G
requested review from
Rob-Hague,
WojciechNagorski and
drieseng
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed SshCommand does not have a method for sending signals although it is supported by the channel and underlying system.
This code:
All signals listed in https://datatracker.ietf.org/doc/html/rfc4254#section-6.9 are supported and use their libc compatible values in case someone needs conversion from libc.
Still missing are tests, but i don't understand the test project structure, if someone could help me out there that would be great.