Add interface to SshCommand#1775
Open
MartinHvolgaardHansen wants to merge 3 commits intosshnet:developfrom
Open
Add interface to SshCommand#1775MartinHvolgaardHansen wants to merge 3 commits intosshnet:developfrom
MartinHvolgaardHansen wants to merge 3 commits intosshnet:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds an interface to SshCommand to enable easy mocking in dependent tests.
A quick overview of the changes:
There are alternatives to achieve testability, but for SSH.NET to be truly testable in future projects, this interface is needed.
Did I miss anything? Let me know, and I'll make sure to amend it.
Thanks for reviewing and your time, and a big thanks to the authors and contributors.