Fix scale parameter for polygons with datashader#555
Merged
Conversation
The datashader rendering path only applied the `scale` parameter to circle geometries (Points with radius). Polygon and MultiPolygon geometries were passed through unscaled. This adds scaling via `shapely.affinity.scale()` around each geometry's centroid, matching the existing matplotlib path behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
+ Coverage 73.66% 73.87% +0.20%
==========================================
Files 10 10
Lines 2738 2752 +14
Branches 637 639 +2
==========================================
+ Hits 2017 2033 +16
+ Misses 447 446 -1
+ Partials 274 273 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scaleparameter for shapes has no impact on polygons with datashader #473: thescaleparameter inrender_shapes()had no effect on Polygon/MultiPolygon geometries when using the datashader backendshapely.affinity.scale()around each geometry's centroid in the datashader path, matching existing matplotlib behaviortest_plot_can_scale_polygons_datashader