Open
Conversation
Contributor
On second thought: It’s not correct. |
Contributor
Author
|
Yeah, i've just removed it entirely and it's now just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes soutaro/steep#2124 by updating
class.rbs. Few important things to note that I'd like input on:[self: Class]toClass#initialize—it seems correct, but if we should remove that LMKAnd other things to note:
Classdefines both a singletonClass.allocateand an instanceClass#allocate. I've gone ahead and included both for completeness, and it shouldn't matterinheritedis now private (as it should be) and returnsvoid(as nothing in Ruby uses its return value)new's signature now accepts anythingattached_objectstill returnsuntyped