conformance: Fix questionable assert_type() with known class#2226
Merged
carljm merged 2 commits intopython:mainfrom Mar 25, 2026
Merged
conformance: Fix questionable assert_type() with known class#2226carljm merged 2 commits intopython:mainfrom
carljm merged 2 commits intopython:mainfrom
Conversation
The previous test asserted that type checkers should consider a direct reference to the class to be equivalent to a type[] usage. But it is entirely reasonable for type checkers to recognize the direct class reference as an instance of a more precise singleton type, as ty does. (Pycroscope also kind of does this but I'm still working on adjusting its behavior.) I replaced this test with assertions about the assignability of the direct class reference to a few type[] variants.
carljm
approved these changes
Mar 25, 2026
AlexWaygood
approved these changes
Mar 25, 2026
srittau
added
the
topic: conformance tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous test asserted that type checkers should consider a direct
reference to the class to be equivalent to a type[] usage. But it is
entirely reasonable for type checkers to recognize the direct class
reference as an instance of a more precise singleton type, as ty does.
(Pycroscope also kind of does this but I'm still working on adjusting its
behavior.)
I replaced this test with assertions about the assignability of the
direct class reference to a few type[] variants.