Skip to content

gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expression failure#146246

Merged
serhiy-storchaka merged 6 commits intopython:mainfrom
Wulian233:initconfig
Mar 25, 2026
Merged

gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expression failure#146246
serhiy-storchaka merged 6 commits intopython:mainfrom
Wulian233:initconfig

Conversation

@Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Mar 21, 2026

@Wulian233
Copy link
Contributor Author

@serhiy-storchaka Could you please help review this PR? Thank you very much!

@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 24, 2026
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit 9343518 into python:main Mar 25, 2026
49 checks passed
@miss-islington-app
Copy link

Thanks @Wulian233 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2026
…sion failure (pythonGH-146246)

(cherry picked from commit 9343518c6f413b2231b17c56065e5cf823aa0d2a)

Co-authored-by: Wulian233 <1055917385@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2026
…sion failure (pythonGH-146246)

(cherry picked from commit 9343518)

Co-authored-by: Wulian233 <1055917385@qq.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 25, 2026

GH-146432 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 25, 2026
@bedevere-app
Copy link

bedevere-app bot commented Mar 25, 2026

GH-146433 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 25, 2026
serhiy-storchaka pushed a commit that referenced this pull request Mar 25, 2026
…ssion failure (GH-146246) (GH-146433)

(cherry picked from commit 9343518)

Co-authored-by: Wulian233 <1055917385@qq.com>
@Wulian233 Wulian233 deleted the initconfig branch March 25, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants