Open
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
Mar 24, 2026
Comment on lines
+146
to
+149
| $calledOnType = $scope->getType($callbackArg->value); | ||
| if (!$calledOnType->isCallable()->yes()) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
since the following loop might return early, we could move this 4 lines nearer to the usage in line 174 to prevent unnecessary work
staabm
reviewed
Mar 24, 2026
Comment on lines
1131
to
1132
| } | ||
| $this->analyse([__DIR__ . '/data/call-user-func-array.php'], $errors); | ||
| $this->analyse([__DIR__ . '/data/call-user-func-array-named-args.php'], $errors); | ||
| } |
Contributor
There was a problem hiding this comment.
is call-user-func-array.php no longer tested in this rule?
Contributor
|
issue-bot shows a new error with phpstan/phpstan#8214 .. might indicate we miss splat operator support...? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #5282
This copy the existing behavior of
call_user_funcbut forcall_user_func_array.Closes phpstan/phpstan#5942
Closes phpstan/phpstan#5934