Skip to content

standard: Add enum SortDirection #21501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TimWolla wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −5
Draft

standard: Add enum SortDirection #21501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/reflection/tests/ReflectionExtension_getClassNames_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ foreach ($classNames as $className) {
AssertionError
Directory
RoundingMode
SortDirection
StreamBucket
__PHP_Incomplete_Class
php_user_filter
1 change: 1 addition & 0 deletions ext/standard/array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
/* }}} */

ZEND_DECLARE_MODULE_GLOBALS(array)
PHPAPI zend_class_entry *sort_direction_ce;

/* {{{ php_array_init_globals */
static void php_array_init_globals(zend_array_globals *array_globals)
Expand Down
1 change: 1 addition & 0 deletions ext/standard/basic_functions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ PHP_MINIT_FUNCTION(basic) /* {{{ */
assertion_error_ce = register_class_AssertionError(zend_ce_error);

rounding_mode_ce = register_class_RoundingMode();
sort_direction_ce = register_class_SortDirection();

BASIC_MINIT_SUBMODULE(var)
BASIC_MINIT_SUBMODULE(file)
Expand Down
5 changes: 5 additions & 0 deletions ext/standard/basic_functions.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@
*/
const SORT_FLAG_CASE = UNKNOWN;

enum SortDirection {
case Ascending;
case Descending;
}

/**
* @var int
* @cvalue PHP_CASE_LOWER
Expand Down
13 changes: 12 additions & 1 deletion ext/standard/basic_functions_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 9 additions & 4 deletions ext/standard/basic_functions_decl.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions ext/standard/php_array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define ARRAY_FILTER_USE_BOTH 1
#define ARRAY_FILTER_USE_KEY 2

extern PHPAPI zend_class_entry *sort_direction_ce;

ZEND_BEGIN_MODULE_GLOBALS(array)
bucket_compare_func_t *multisort_func;
bool compare_deprecation_thrown;
Expand Down
Loading