PERF: pre-compute date/datetime column classification in SAS7BDAT reader#64768
Draft
jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
Draft
PERF: pre-compute date/datetime column classification in SAS7BDAT reader#64768jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
Conversation
jbrockmendel
added
Performance
…der (pandas-dev#47339) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jbrockmendel
force-pushed
the
perf-sas-column-classify
branch
from
f566a9b to
2978841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parse_metadatainstead of checking set membership against 67+20 element tuples per column per chunk in_chunk_to_dataframe_chunk_to_dataframe, scaling with columns x chunkstest_corrupt_readexpected error message sincecolumn_countis now accessed beforerow_countcloses #47339
Test plan
pytest pandas/tests/io/sas/— all 117 tests pass🤖 Generated with Claude Code