DEPR: dropna in pivot_table and crosstab#64759
Draft
jbrockmendel wants to merge 3 commits intopandas-dev:mainfrom
Draft
DEPR: dropna in pivot_table and crosstab#64759jbrockmendel wants to merge 3 commits intopandas-dev:mainfrom
jbrockmendel wants to merge 3 commits intopandas-dev:mainfrom
Conversation
…ions Replace kh_get + kh_put patterns with kh_put alone (checking ret for new-vs-existing), removing a redundant hash computation and probe per element in value_count, _unique, duplicated(keep=False), and get_labels_groupby. Also clean up the vendored khash.h: - Remove dead deletion-tracking code from kh_put/kh_get (deletions are disabled via __ac_isdel=0, but site variable and branches remained) - Fix kh_clear to use 0xff (all-empty) instead of 0xaa, which was a leftover from the original 2-bit-per-slot flag scheme - Remove unreachable shrink path from kh_put resize trigger - Fix value_count object pre-sizing from n//10 to n Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dropnaparameter inpivot_tableandcrosstabwithPandas4Warning(GH#53521)observed=dropnawas incorrectly passed to_add_marginsinpivot_table, ignoring the user'sobservedsettingobserved=dropnacoupling incrosstabobservedparameter tocrosstab(previously unavailable)closes #53521
Test plan
dropna=are wrapped withtm.assert_produces_warning(Pandas4Warning)🤖 Generated with Claude Code