Update docstring for methods where inplace keyword is deprecated#64757
Open
tamhahn wants to merge 2 commits intopandas-dev:mainfrom
Open
Update docstring for methods where inplace keyword is deprecated#64757tamhahn wants to merge 2 commits intopandas-dev:mainfrom
tamhahn wants to merge 2 commits intopandas-dev:mainfrom
Conversation
…place merge to keep local feature branch up-to-date with upstream/main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a deprecation note to the docstring of DataFrame.rename only.
Please let me know whether this (very general) wording is correct, and I will add it for the other methods mentioned in #63207 to this PR (or a separate one, if that's preferred).
All code checks passed
Yes, pre-commit hooks ran and passed (it skipped tests for "no files to check" which I assume is normal behavior)
I have reviewed and followed all the contribution guidelines
Yes