PERF: short-circuit fragmentation check in BlockManager.insert#64756
Open
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Open
PERF: short-circuit fragmentation check in BlockManager.insert#64756jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Conversation
Add a len(self.blocks) > 100 guard before the O(n) block iteration and get_option call in insert(), since the non-extension block count can never exceed the total block count. closes pandas-dev#57641 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
len(self.blocks) > 100guard inBlockManager.insertto skip the O(n) block iteration andget_optioncall when the block count is smallcloses #57641
Benchmarks
InsertColumns.time_insertInsertColumns.time_insert_middleInsertColumns.time_assign_with_setitemTest plan
test_insert.py,test_block_internals.py)🤖 Generated with Claude Code