BUG: Fix _replace_regex mutating StringArray in-place for non-inplace replace#64752
Open
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Open
BUG: Fix _replace_regex mutating StringArray in-place for non-inplace replace#64752jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Conversation
… replace closes pandas-dev#57733 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unblocks #57733
Block._replace_regexcallsself.astype(np.dtype(object))when the replacement value can't be held in the current dtype. ForStringArray(backed by an object ndarray), this astype chain returns a block whose values share memory with the originalStringArray._ndarray— because the underlying conversion is object→object withcopy=False, which is a no-op.replace_regexthen mutates this shared array in-place, corrupting the original.Fix: call
_maybe_copy(inplace=True)on the astype result before mutation, which copies only when the block shares refs with the original (i.e., when astype returned a view).Reproducer:
🤖 Generated with Claude Code