[FEATURE REQUEST] Allow to go to the destination folder when the copy/move operation is finished by mykh-hailo · Pull Request #4802 · owncloud/android

mykh-hailo · 2026-03-11T03:27:27Z

Related Issues

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

joragua · 2026-03-11T09:47:33Z

Thanks for your contribution @mykh-hailo! 🍻 Just a small note before the CR: please be careful with the branch name. The branch prefixes we use in the project are: feature/, fix/ , technical/ and improvement/. Do not forget to take a look to CONTRIBUTING.md to make sure everything follows the guidelines.

I will take care of this as soon as possible and I'll ping you when it's ready 😄

mykh-hailo · 2026-03-12T11:56:15Z

@joragua I'd appreciate it if you share any feedback on the result.

mykh-hailo · 2026-03-13T11:37:22Z

@joragua Can you check my PR please?

joragua · 2026-03-16T10:07:56Z

@mykh-hailo I'll ping you when the CR is finished. Stay tuned! 😄

mykh-hailo · 2026-03-18T22:04:05Z

@joragua Can you provide me any updates on this?
I like your fast feedback and update.
😄

joragua · 2026-03-20T13:53:18Z

Hi @mykh-hailo! I'm working on the PR but it will not be available until next week. I'll ping you once it's done. No worries! 😄 Thanks for your patience!

joragua

Nice job @mykh-hailo! 🙌🏻 Somme comments here.

NOTE: I'd add a release note since this is an important and useful improvement for end users. They should be aware of it this and see the new feature in the release notes screen. You can add a new entry in ReleaseNotesViewModel.kt with an appropriate title and subtitle. Let us know if you have any question about this process. 😄

owncloudApp/src/main/java/com/owncloud/android/extensions/ActivityExt.kt

joragua · 2026-03-23T11:20:14Z

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

+        } else {
+            showMessageInSnackbar(R.id.list_layout, message)
+        }
+        copyMoveTargetFolder = null


Just a question: Is it necessary to set null at the end? Since the copyMoveTargetFolder value is set at the begin of requestMoveOperation and copyMoveOperation methods

Just a question: Is it necessary to set null at the end? Since the copyMoveTargetFolder value is set at the begin of requestMoveOperation and copyMoveOperation methods

What about this? 🤔

owncloudApp/src/main/res/values/strings.xml

mykh-hailo · 2026-03-23T15:44:01Z

@joragua Thank you for your feedback.
I updated the code for it.
Could you check it please?

joragua

Some comments and it's ready @mykh-hailo! 😄

We usually use refactor: prefix in commits when we change the code but keep the same behavior (string changes, method refactoring...) We use the prefix fix: when something is broken and we must fix it. My suggestion: refactor: update string resource
The prefix used for release note is feat: since it's a new improvement in the app that end users can see. My suggestion: feat: add release note

You can do an interactive rebase and change the name of the commits applying my suggestions, in order to follow the project convention for commits. Let us know if you have any question about the process 🍻

joragua · 2026-03-26T11:17:10Z

...loudApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt

+                        showSnackbarWithAction(
+                            message = getString(R.string.sync_fail_ticker_unauthorized),
+                            actionText = getString(R.string.auth_oauth_failure_snackbar_action),
+                            action = {


I think you removed the snackbar duration from here, and it should be displayed indefinite: duration = Snackbar.LENGTH_INDEFINITE

joragua · 2026-03-26T11:17:35Z

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

+        } else {
+            showMessageInSnackbar(R.id.list_layout, message)
+        }
+        copyMoveTargetFolder = null


Just a question: Is it necessary to set null at the end? Since the copyMoveTargetFolder value is set at the begin of requestMoveOperation and copyMoveOperation methods

What about this? 🤔

joragua · 2026-03-26T11:17:51Z

owncloudApp/src/main/res/values/strings.xml

    <string name="move_file_invalid_into_descendent">It is not possible to move a folder into a descendant.</string>
    <string name="move_file_invalid_overwrite">The file exists already in the destination folder.</string>
    <string name="move_file_error">An error occurred while trying to move this file or folder.</string>
+    <string name="move_success_msg">File moved correctly</string>


Suggested change

<string name="move_success_msg">File moved correctly</string>

<string name="move_file_correctly">File moved correctly</string>

joragua · 2026-03-26T11:18:04Z

owncloudApp/src/main/res/values/strings.xml

    <string name="copy_file_invalid_into_descendent">It is not possible to copy a folder into a descendant.</string>
    <string name="copy_file_invalid_overwrite">The file exists already in the destination folder.</string>
    <string name="copy_file_error">An error occurred while trying to copy this file or folder.</string>
+    <string name="copy_success_msg">File copied correctly</string>


Suggested change

<string name="copy_success_msg">File copied correctly</string>

<string name="copy_file_correctly">File copied correctly</string>

joragua · 2026-03-26T11:18:18Z

owncloudApp/src/main/res/values/strings.xml

+    <string name="release_notes_4_8_0_title_action_to_copy_or_move_destination_folder">Action to copy/move destination folder</string>
+    <string name="release_notes_4_8_0_subtitle_action_to_copy_or_move_destination_folder">Added a snackbar action to quickly navigate to the destination folder after copy/move operations.</string>


We don't usually include technical words in the release notes such as snackbar.

My suggesstion:

Suggested change

<string name="release_notes_4_8_0_title_action_to_copy_or_move_destination_folder">Action to copy/move destination folder</string>

<string name="release_notes_4_8_0_subtitle_action_to_copy_or_move_destination_folder">Added a snackbar action to quickly navigate to the destination folder after copy/move operations.</string>

<string name="release_notes_4_8_0_title_action_to_copy_or_move_destination_folder">Navigate to destination folder</string>

<string name="release_notes_4_8_0_subtitle_action_to_copy_or_move_destination_folder">New action to navigate to the destination folder when a file is copied or moved</string>

Do you have any idea for the release note @jesmrec? (open to discussion)

That's right. Release notes target any kind of user, so, we can not assume that technical words are understood by everyone. Better to use basic language. About your approach, @joragua, it's ok with tiny changes from my side #

Suggested change

<string name="release_notes_4_8_0_title_action_to_copy_or_move_destination_folder">Action to copy/move destination folder</string>

<string name="release_notes_4_8_0_subtitle_action_to_copy_or_move_destination_folder">Added a snackbar action to quickly navigate to the destination folder after copy/move operations.</string>

<string name="release_notes_4_8_0_title_action_to_copy_or_move_destination_folder">Navigation to target folder</string>

<string name="release_notes_4_8_0_subtitle_action_to_copy_or_move_destination_folder">New action to navigate to the destination folder when a file or folder is copied or moved<</string>

Nice! @mykh-hailo I'd go for the release note approach that @jesmrec commented 🙌🏻

…tension

mykh-hailo force-pushed the feat/copy_snack_bar branch 2 times, most recently from b088f36 to 9a416e0 Compare March 11, 2026 03:46

joragua linked an issue Mar 11, 2026 that may be closed by this pull request

[FEATURE REQUEST] Allow to go to the destination folder when the copy/move operation is finished #4379

Open

10 tasks

joragua requested changes Mar 23, 2026

View reviewed changes

mykh-hailo added 3 commits March 23, 2026 09:37

feat: show destination folder snackbar for copy/move operations

a49556a

fix: hide three-dot menu in folder picker mode

d1c2bea

chore: add changelog

dfb979a

mykh-hailo force-pushed the feat/copy_snack_bar branch 2 times, most recently from d886716 to a2d1b92 Compare March 23, 2026 14:27

mykh-hailo requested a review from joragua March 24, 2026 07:07

This comment was marked as outdated.

Sign in to view

joragua requested changes Mar 26, 2026

View reviewed changes

mykh-hailo added 2 commits March 26, 2026 08:37

refactor: refactor Snackbar usage to shared showSnackbarWithAction ex…

4416a83

…tension

fix: remove unneccessary code

05b1153

mykh-hailo force-pushed the feat/copy_snack_bar branch from a2d1b92 to c394298 Compare March 26, 2026 12:43

mykh-hailo added 2 commits March 26, 2026 08:46

refactor: update string resource

dad47d3

feat: add release note

2468ae7

mykh-hailo force-pushed the feat/copy_snack_bar branch from c394298 to 2468ae7 Compare March 26, 2026 12:46

mykh-hailo requested review from jesmrec and joragua March 26, 2026 12:48

	<string name="move_success_msg">File moved correctly</string>
	<string name="move_file_correctly">File moved correctly</string>

	<string name="copy_success_msg">File copied correctly</string>
	<string name="copy_file_correctly">File copied correctly</string>

		<string name="release_notes_4_8_0_title_action_to_copy_or_move_destination_folder">Action to copy/move destination folder</string>
		<string name="release_notes_4_8_0_subtitle_action_to_copy_or_move_destination_folder">Added a snackbar action to quickly navigate to the destination folder after copy/move operations.</string>

Conversation

mykh-hailo commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

Uh oh!

joragua commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mykh-hailo commented Mar 12, 2026

Uh oh!

mykh-hailo commented Mar 13, 2026

Uh oh!

joragua commented Mar 16, 2026

Uh oh!

mykh-hailo commented Mar 18, 2026

Uh oh!

joragua commented Mar 20, 2026

Uh oh!

joragua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mykh-hailo commented Mar 23, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

joragua left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mykh-hailo commented Mar 11, 2026 •

edited

Loading

joragua commented Mar 11, 2026 •

edited

Loading