Skip to content

Address Rust Package build#830

Merged
mjp41 merged 1 commit intomicrosoft:mainfrom
mjp41:rust_package
Mar 24, 2026
Merged

Address Rust Package build#830
mjp41 merged 1 commit intomicrosoft:mainfrom
mjp41:rust_package

Conversation

@mjp41
Copy link
Member

@mjp41 mjp41 commented Mar 24, 2026

Addresses #828

Also, finally tidying, so we can release an updated Rust package and bump the snmalloc version number in one go.

@mjp41
Copy link
Member Author

mjp41 commented Mar 24, 2026

@SchrodingerZhu I have also put some draft release notes on the release page. Could you take a look at those as well. Thanks

Copy link
Collaborator

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #828 by adding a repository-level Cargo workspace so snmalloc-rs can be consumed via a git dependency pointing at the repo root, while also aligning the Rust crate documentation/versioning for a 0.7.4 release.

Changes:

  • Add a top-level Cargo.toml workspace that includes snmalloc-rs, snmalloc-sys, and xtask.
  • Remove the sub-workspace definition from snmalloc-rs/Cargo.toml now that the workspace is defined at the repo root.
  • Update Rust crate docs/changelog to reflect version 0.7.4.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
snmalloc-rs/README.md Updates the dependency snippet to snmalloc-rs = "0.7.4".
snmalloc-rs/Cargo.toml Removes the local [workspace] section, leaving this as a package manifest within the new root workspace.
snmalloc-rs/CHANGELOG.md Adds a 0.7.4 entry describing upstream tracking and repository move context.
Cargo.toml Introduces a repository-level Rust workspace with resolver v2 and the Rust crates as members.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mjp41 mjp41 merged commit cd2b19b into microsoft:main Mar 24, 2026
195 checks passed
@mjp41
Copy link
Member Author

mjp41 commented Mar 24, 2026

@SchrodingerZhu, If I release this branch with a tag 0.7.4 can you create the package on crates?

@mjp41 mjp41 deleted the rust_package branch March 24, 2026 15:21
@SchrodingerZhu
Copy link
Collaborator

sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants