Merged
Conversation
Member
Author
|
@SchrodingerZhu I have also put some draft release notes on the release page. Could you take a look at those as well. Thanks |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #828 by adding a repository-level Cargo workspace so snmalloc-rs can be consumed via a git dependency pointing at the repo root, while also aligning the Rust crate documentation/versioning for a 0.7.4 release.
Changes:
- Add a top-level
Cargo.tomlworkspace that includessnmalloc-rs,snmalloc-sys, andxtask. - Remove the sub-workspace definition from
snmalloc-rs/Cargo.tomlnow that the workspace is defined at the repo root. - Update Rust crate docs/changelog to reflect version
0.7.4.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
snmalloc-rs/README.md |
Updates the dependency snippet to snmalloc-rs = "0.7.4". |
snmalloc-rs/Cargo.toml |
Removes the local [workspace] section, leaving this as a package manifest within the new root workspace. |
snmalloc-rs/CHANGELOG.md |
Adds a 0.7.4 entry describing upstream tracking and repository move context. |
Cargo.toml |
Introduces a repository-level Rust workspace with resolver v2 and the Rust crates as members. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@SchrodingerZhu, If I release this branch with a tag 0.7.4 can you create the package on crates? |
Collaborator
|
sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #828
Also, finally tidying, so we can release an updated Rust package and bump the snmalloc version number in one go.