Open
Conversation
…ulp-header with gulp-prepend removed gh-pages and replaced gulp-header with gulp-prepend, both depend on lodash.templae which has a vulnerability in all of its version. gh-pages is not required anymore as we post public docs to MS docs and not github. replaced gulp-header with gulp-prepend which serves the same purpose - adds the header to generated d.ts files. Example of the header: // powerbi-client v2.23.1 // Copyright (c) Microsoft Corporation. // Licensed under the MIT License. Related work items: #1379776
fixed s360 vulnerabilities of braces and ws. Removed watch task which is not working. Related work items: #1379776
Playground V1 is currently used for sample embedding, mainly for troubleshooting and debugging. We don't need the showcases here as they are available and maintained in Playground V2 ---- #### AI description (iteration 1) #### PR Classification Code cleanup to remove showcases from the demo. #### PR Summary This pull request removes the entire `quick_visual_creator` showcase from the demo. - Deleted `showcase_quick_visual_creator.js` file, which included all related state management, visual embedding, dropdown initialization, and event handling functions.
Fixing CFS bugs by enforcing using an Azure feed during npm restore. Test run with verbose logging: https://dev.azure.com/powerbi/Embedded/_build/results?buildId=11247120&view=results ---- #### AI description (iteration 1) #### PR Classification Code enhancement to improve npm installation process. #### PR Summary Enhanced the npm installation command in the PowerShell script to use a specific global configuration file and increased log verbosity. - Modified `/.pipelines/restore.ps1` to include `--globalconfig "$(Build.SourcesDirectory)\.npmrc"` and `--loglevel verbose` in the npm install command. Related work items: #1434106
…_distribution fixed official pipeline signing profile to external_distribution ---- #### AI description (iteration 1) #### PR Classification Bug fix #### PR Summary This pull request updates the signing profile in the official pipeline configuration to use the external distribution profile. - Changes in `/.pipelines/OneBranch.Official.yml`: Updated `signing_profile` from `internal_azure_service` to `external_distribution`.
#### AI description (iteration 1) #### PR Classification Documentation update #### PR Summary Updated the `README.md` to include a new "Support" section, providing information on how to get help and submit feature requests. - Added "Support" section to `README.md` with links for feature requests, bug reports, technical assistance, and additional support. Related work items: #1522129
https://liquid.microsoft.com/Web/Compliance/Run/?product=PRD-170898&requirement=Microsoft.Security.CodeQL.10000&collection=MS.Security&copilot_promptid=C3DAE81E-CE96-46ED-BC94-840F0284B72C&editing=1&view=771901 Using workaround from https://portal.microsofticm.com/imp/v5/incidents/details/558277475/summary .
…nge should be applied on other embed repos added auto PR comment to check if change should be applied on other embed repos. When there is a change to a file configured for all of embed repos, we usually need to apply the change to all of the repos we maintain. For example - the following PR where we updated the signing profile: https://dev.azure.com/powerbi/Embedded/_git/powerbi-javascript/commit/3c09aa92c8e1a4ffe7d081761eddc62b4e71b04b?refName=refs%2Fheads%2Fmaster&path=%2F.pipelines%2FOneBranch.Official.yml&_a=compare Many times these changes are applied by ES team and this comment will help them to understand which repositories they need to change ---- #### AI description (iteration 1) #### PR Classification New feature #### PR Summary This pull request adds an automated comment feature to check if changes should be applied to other embedded repositories. - Added `/.config/merlinbot/nitpicker.yaml` to configure auto PR comments for validation of changes across embed repositories.
… layout instead of hardcoding values ## Description When embedding a visual, there is noticeable space on the left and right sides of the container, even after applying fitToWidth in the displayOption of the custom layout. - Applying `fitToWidth` in the initial embed configuration results in extra space on both sides. - When the `fitToWidth` display setting is triggered by a button click using the updateSettings method, the visual adjusts correctly without any extra spacing.  #### PR Summary This pull request addresses a visual bug where the embedded visual does not fit correctly within the container by dynamically setting custom layout values. - `src/visual.ts`: Modified to dynamically set `displayOption`, `pageSize`, and `pagesLayout` from the configuration if available, otherwise use default values. ### Checklist #### TypeScript | Checklist Point | Description | Status (Yes/No/NA) | |-------------------------|------------------------------------------------------------------------------------------------------------------|--------------------| | Imports | Review import statements and ensure that only required modules and components are imported. Unused imports should be removed | Yes | | Coding Standards | Ensure that the code follows consistent indentation, formatting, and naming conventions | Yes | | Type Annotations | Check for proper type annotations for variables, function parameters, and return types to enhance code clarity and catch potential errors | Yes | | Services | Confirm that services are being used appropriately for data retrieval and manipulation | Yes | | Error Handling | Check for proper error handling, including catching and handling exceptions or errors that might occur during component execution. | Yes | | Lifecycle Hooks | Verify that lifecycle hooks are used correctly and efficiently | NA | #### CSS | Checklist Point | Status (Yes/No/NA) | |---------------------------------------------------------------|--------------------| | Is CSS class or id prefixed with a string specific to project? | Yes | | Is use of `!important` avoided? | Yes | | Are CSS classes created logically so that they can be reused? | Yes | | Are unused classes/rules removed? | Yes | | Have you followed proper formatting in your CSS files? ...
### PR Classification This PR involves the migration of the powerbi-javascript NPM release process from a classical pipeline to a YAML-based pipeline. ### PR Summary This pull request introduces a YAML pipeline for the release of the `powerbi-javascript` NPM package. - Added `/.pipelines/powerbi-javascript-npm-release.yml` to define the stages and jobs for internal and external NPM publishing, approval processes, and marking the latest version. This PR introduces a new pipeline for the powerbi-javascript. The pipeline is designed to: - Publish the NPM package internally. - Manually trigger and obtain approval to release the package to the external feed. - Release the package externally upon approval, using the esrpRelease task. - Manually trigger and obtain approval to mark the external release as the latest version. - Mark the released package as the latest version after verifying external release success and approval. Test run with verbose logging: https://dev.azure.com/powerbi/Embedded/_build/results?buildId=12736900&view=results ### Pipeline stage execution snapshot  Related work items: #1516697
### Checklist | **Checklist Point** | **Description** | **Status** | |------------------------------|------------------------------------------------------------|------------| | **Syntax Validation** | Ensure the YAML syntax is correct (no tabs, proper indentation). | Yes | | **Environment Variables** | Check if environment variables are securely defined. | Yes | | **Dependencies** | Verify all required dependencies are installed or defined. | Yes | | **Triggers** | Confirm pipeline triggers (e.g., branches, PRs) are correctly configured. | Yes | | **Artifacts** | Validate build artifacts are properly generated and stored. | Yes | ### PR Classification This PR involves the migration of the powerbi-javascript NuGet release process from a classical pipeline to a YAML-based pipeline. ### PR Summary This pull request introduces a YAML pipeline for the release of the powerbi-javascript NuGet package. - Added `/.pipelines/powerbi-javascript-nuget-release.yml` to define the pipeline stages for internal and external NuGet package publishing. - Included manual approval stage for external publishing. This PR introduces a new pipeline for the powerbi-javascript NuGet release. The pipeline is designed to: - Publish the NuGet package internally. - Manually trigger and obtain approval to release the package to the external feed. - Release the package externally upon approval. Test run with verbose logging: https://dev.azure.com/powerbi/Embedded/_build/results?buildId=12816842&view=results ### Pipeline stage execution snapshot  Related work items: #1562018
Following SFI alerts, we were requested to fix a minor issue in the syntaxHighlighter.js files.   However, the demos are not maintained, and they are duplications of playground v1 codebase, which was deprecated and removed. ---- #### AI description (iteration 1) #### PR Classification Code cleanup #### PR Summary This pull request removes all demo-related files and updates the `README.md` to reflect these changes. - Deleted all files under the `demo` directory, including scripts, styles, images, and HTML files. - Updated `README.md` to remove references to the deleted demo and provide links to alternative resources.
As part of wave4 security item we need to Eliminate access to Codesigning from Corp Tenants, this PR is to use PME resources for esrp signing task. Here is the wiki of esrp signing task https://dev.azure.com/powerbi/Trident/_wiki/wikis/Trident.wiki/87762/Engineering-Systems-Shared-ESRP-Registration **Runs:-** **powerbi-javascript NPM release:-** https://dev.azure.com/powerbi/Embedded/_build/results?buildId=13345984&view=results ---------------------------------------- #### AI description (iteration 1) #### PR Classification Code update to use PME resources for ESRP signing. #### PR Summary This pull request updates the ESRP signing process to utilize PME resources. - `.pipelines/powerbi-javascript-npm-release.yml`: Updated `EsrpRelease` task to use PME resources, including changes to `keyvaultname`, `signcertname`, and `domaintenantid`. Added `npmAuthenticate` task for NPM authentication. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1619784
…and added azurepipelines-coverage.yml for QCS requirement- powerbi-javascript As part of this PR, unit tests have been migrated to the buddy pipeline from this classic pipeline - https://dev.azure.com/powerbi/Embedded/_build?definitionId=6720&_a=summary Also, code coverage has been onboarded and enabled. Please refer to the files changed for detailed info. Development Test Run: https://dev.azure.com/powerbi/Embedded/_build/results?buildId=13760700&view=results CodeCoverage Tab: https://dev.azure.com/powerbi/Embedded/_build/results?buildId=13760700&view=codecoverage-tab #### AI description (iteration 1) #### PR Classification New feature to enable code coverage and integrate with Azure Pipelines for QCS requirement. #### PR Summary This pull request introduces code coverage capabilities and integrates them with Azure Pipelines. - `.pipelines/OneBranch.Buddy.yml`: Added steps to install Puppeteer, run Karma tests, and publish test and code coverage results. - `karma.conf.js`: Configured Karma to include coverage and TypeScript support, added custom Chrome headless launcher. - `tsconfig.json`: Included `test/**/*.ts` files for TypeScript compilation. - `azurepipelines-coverage.yml`: Added new file to define code coverage targets and status reporting. - `package.json`: Added `karma-coverage` dependency. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1657919
#### AI description (iteration 1) #### PR Classification Dependency upgrade. #### PR Summary This pull request upgrades the "powerbi-models" dependency to version 2.0.1, ensuring the project uses the latest model release. - `package.json`: Updated the "powerbi-models" version from "^1.14.0" to "^2.0.1". <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1866964
#### AI description (iteration 1) #### PR Classification Version update for a new release. #### PR Summary This pull request updates the package version in the `package.json` file to prepare the library for the 3.0.0 release. - `package.json`: Changed version from "2.23.1" to "3.0.0". <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1866964
fixed internal release and approval steps ---- #### AI description (iteration 1) #### PR Classification Bug fix addressing misconfigurations in the internal release and approval pipeline steps. #### PR Summary This PR revises the pipeline configuration to ensure the correct build artifacts are used and the approval process is streamlined for production releases. It fixes the internal release steps and adjusts the approval stage for improved deployment consistency. - `/.pipelines/powerbi-javascript-npm-release.yml`: Added a task to download build files from the official pipeline. - `/.pipelines/powerbi-javascript-npm-release.yml`: Updated the npm publish step to use the downloaded artifact directory. - `/.pipelines/powerbi-javascript-npm-release.yml`: Renamed and reconfigured the approval stage and job, including updated pool settings and environment variables. - `/.pipelines/powerbi-javascript-npm-release.yml`: Modified the external release stage dependency to reference the new approval stage. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1852212
#### AI description (iteration 1) #### PR Classification This pull request is a version bump upgrade (v2.23.8) that also refactors module import paths and build configurations. #### PR Summary The release updates the client’s TypeScript definitions and internal module paths to a new “src/…” structure and revises build pipeline settings accordingly. - Updated module declarations by moving many files from legacy paths (e.g. "FilterBuilders", "service") to "src/FilterBuilders", "src/service", etc. - Modified references in key files (e.g. "powerbi-client", "report", "dashboard", "qna") to reflect the new directory structure. - Adjusted pipeline YAML scripts to use updated working directories and artifact paths. - Bumped all relevant version references to 2.23.8 for accurate SDK versioning. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1869266
Version bump 2.23.8 ---- #### AI description (iteration 1) #### PR Classification This pull request updates the library’s version to 2.23.8 in preparation for a new release. #### PR Summary The changes update version strings across multiple files ensuring consistency for the new release: - Updated version comments in `dist/powerbi.js` and `dist/powerbi.min.js` from "2.23.2" to "2.23.8". - Modified the version in `src/config.ts` to "2.23.8". - Bumped the package version in `package.json` to "2.23.8". - Revised the version comment in `dist/powerbi-client.d.ts` to "2.23.8". <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1869266
2 issues in generated d.ts file: 1. module names contains "src/" prefix - this breaks package consumers - "import x from powerbi-client" will fail with invalid modules names. 2. tests typings are included in d.ts file Caused by: https://dev.azure.com/powerbi/Embedded/_git/powerbi-javascript/commit/ad7bf5aadbee40c752f01cb8535357c5ce854512?refName=refs/heads/master&path=/tsconfig.json&_a=contents This change will not effect tests execution ---- #### AI description (iteration 1) #### PR Classification This pull request fixes a bug in the generation of the Power BI TypeScript declarations by cleaning up extra test module declarations and correcting module path names. #### PR Summary The changes update the generated `powerbi-client.d.ts` file by removing unnecessary test-related module declarations and standardizing module paths (removing the redundant `src/` prefix). Additionally, the tsconfig update excludes test files from the build to ensure only production code is generated. - In `dist/powerbi-client.d.ts`, test modules (e.g., mocks and utilities) were removed and module paths were updated. - Several modules (e.g., `FilterBuilders/index`, `powerbi-client`, `report`, `visual`) now use adjusted paths without the `src/` prefix. - The `tsconfig.json` file was modified to exclude test directories from the compilation output. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1875016
…ease pipeline Bug in NPM release pipeline: ESRP task releases package as beta because of package.json config set as latest tasks adds latest tag we end up with released package having both beta and latest tages. Resolution: We don't need to release beta versions - this tag is used for "pre-release or experimental" versions - we don't release such. ESRP task will set latest tag when publishing the package if nothing else is configured (documentation ) no need for set as latest release pipeline stage after the above ---- #### AI description (iteration 1) #### PR Classification Release pipeline and configuration update. #### PR Summary This pull request removes the beta tag setup and associated pipeline stages, ensuring that released packages are now tagged as "latest." - `/.pipelines/powerbi-javascript-npm-release.yml`: Removed stages and tasks related to approval and marking the NPM package with the "latest" tag. - `/package.json`: Deleted the "publishConfig" specifying the "beta" tag, allowing the default latest tag to be applied. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1876417
This **automated pull request**, created by **1ES**, is part of the **[Inventory-As-Code](https://aka.ms/inventory-as-code)** onboarding to improve **bug-routing** and **incident response**. #🚀 What’s Changing? - This PR adds inventory metadata to your repository sourced from Product Catalog. - Once merged, this metadata will supersede [Product Catalog](https://product-catalog-web.prod.space.microsoft.com/), which will eventually be retired. You'll manage repository inventory directly via source code. #✅Action Required (Within 14 days): ##1. Review the YAML file(s) - Ensure the repository inventory metadata is accurate. - If the metadata is **incorrect or needs remapping, merge the PR first**, then update the metadata directly in the YAML file. ##2. Approve and Merge the Pull Request - Once reviewed, approve and merge the PR to onboard your repository to Inventory-As-Code. ##3. If you're unsure about the PR or the repo is incorrectly assigned - Visit [Product Catalog](https://product-catalog-web.prod.space.microsoft.com/) and **unassign the repo from the service**. - Use this link: https://product-catalog-web.prod.space.microsoft.com/Product/serviceId. Replace **serviceId** with the service value found in the **es-metadata.yml** file at the root of the PR **Need Assistance?** 📩 **Questions:** [Teams Channel for InventoryAsCode](https://teams.microsoft.com/l/channel/19%3Af82f631a47e248d6a573712683c4a96b%40thread.skype/InventoryAsCode%20Migration?groupId=fa2bea20-1f8d-42f6-9697-ebe18dbb7bc3&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47) 📖 **Learn More:** https://aka.ms/inventory-as-code <!-- GitOpsUserAgent=GitOps.Apps.Job.inventorybootstrapping --> Related work items: #1810457
Fix inventory bootstrap ---- #### AI description (iteration 1) #### PR Classification Bug fix to correct YAML formatting in the inventory bootstrap configuration. #### PR Summary This pull request updates the YAML formatting in `/es-metadata.yml` to properly configure the InventoryAsCode provider for inventory bootstrap. - `/es-metadata.yml`: Adjusted the spacing for the `metadata` field to ensure correct YAML parsing for production settings. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1936124
Whitelist canaryhigh allowed powerbi sov host ---- #### AI description (iteration 1) #### PR Classification Enhancement – updating the allowed PowerBI SOV host whitelist. #### PR Summary This PR updates the regular expression in `src/util.ts` to include the `canaryhigh` domain in the allowed PowerBI SOV whitelist, ensuring that requests from the canaryhigh host are validated correctly. - `src/util.ts`: Modified the regex `allowedPowerBiHostsSovRegex` to add a new option for `.canaryhigh.` among the allowed host patterns. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #2011901
…ion package <!-- COPILOT_AI_GENERATED_START --> This PR bumps the patch version from 2.23.9 to 2.23.10 and rebuilds the distribution package to ensure all artifacts reflect the updated version. ## Changes Made **Version Updates:** - Updated `package.json` to bump the version from `2.23.9` to `2.23.10` - Updated `src/config.ts` to reflect the new version, maintaining consistency across the codebase **Distribution Package Rebuild:** - Rebuilt all distribution files in the `dist/` folder through the official build pipeline - All distribution files now include the updated version in their headers: - `dist/powerbi-client.d.ts` - TypeScript type definitions - `dist/powerbi.js` - Main distribution bundle - `dist/powerbi.min.js` - Minified production bundle The rebuild ensures that: 1. The version banner in all distributed files correctly shows `v2.23.10` 2. The compiled output is in sync with the current source code 3. All build artifacts are generated using the standard build process for consistency All changes follow the standard versioning and release process for the powerbi-javascript library. Fixes: [Bump patch version and rebuild the package in dist folder in https://powerbi.visualstudio.com/Embedded/_git/powerbi-javascript](https://dev.azure.com/powerbi/web/wi.aspx?pcguid=6d8d6e5c-7dbd-4f42-a963-b5d697aa7e39&id=2020101) <p><small class=\"secondary-text\">AI-generated content may be incorrect</small></p> Co-authored-by: Alon Yeshurun <alonyeshurun@microsoft.com> <!-- COPILOT_AI_GENERATED_END --> <!-- GitOpsUserAgent=GitOps.Apps.Server.copilotswe --> Related work items: #2020101
… Pipelines Related work items: #2022623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.