fix awscli patch for new create_nested_client, introduce bats tests#93
Merged
alexrashed merged 2 commits intomasterfrom Aug 5, 2025
Merged
fix awscli patch for new create_nested_client, introduce bats tests#93alexrashed merged 2 commits intomasterfrom
alexrashed merged 2 commits intomasterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
awscliversion1.41.9comes with aws/aws-cli#9602, which changes the way the AWS client is created. This conflicts with our patch for Cloudformation (modifying the S3 endpoint URL).This PR fixes this, and also introduces a proper testing framework (bats).
Fixes #91.
Changes
create_clientfunction forawslocal cloudformation packageandawslocal cloudformation deploy.1.41.9, as well as the versions since then.