Skip to content

fix awscli patch for new create_nested_client, introduce bats tests#93

Merged
alexrashed merged 2 commits intomasterfrom
fix-s3-patch
Aug 5, 2025
Merged

fix awscli patch for new create_nested_client, introduce bats tests#93
alexrashed merged 2 commits intomasterfrom
fix-s3-patch

Conversation

@alexrashed
Copy link
Member

@alexrashed alexrashed commented Aug 4, 2025

Motivation

awscli version 1.41.9 comes with aws/aws-cli#9602, which changes the way the AWS client is created. This conflicts with our patch for Cloudformation (modifying the S3 endpoint URL).
This PR fixes this, and also introduces a proper testing framework (bats).
Fixes #91.

Changes

  • Introduces a new test pipeline which runs certain smoke tests using bats.
  • Fixes the patch of the create_client function for awslocal cloudformation package and awslocal cloudformation deploy.
    • Instead of using a fixed position in the outer frames, we now backtrack to see if we can find the right frame in the whole set of frames. This approach is compatible with the versions before 1.41.9, as well as the versions since then.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cfn deploy & package break with aws-cli version 1.41.9

2 participants