Skip to content

Add the ability to obtain the topology of attached hosts to the datastore#3920

Open
ptrvsrg wants to merge 1 commit intokubernetes-sigs:masterfrom
ptrvsrg:fix-topology-labels-are-assigned-to-datastores
Open

Add the ability to obtain the topology of attached hosts to the datastore#3920
ptrvsrg wants to merge 1 commit intokubernetes-sigs:masterfrom
ptrvsrg:fix-topology-labels-are-assigned-to-datastores

Conversation

@ptrvsrg
Copy link

@ptrvsrg ptrvsrg commented Mar 12, 2026

What this PR does / why we need it:

Fixes a controller crashloop that occurs when vSphere topology tags (region/zone) are assigned to datastore objects. The topology host resolution code did not handle Datastore managed object types, causing a panic/nil pointer dereference during full sync or volume provisioning.

Which issue(s) this PR fixes

Fixes #3919

How was this tested?

  • Manual testing on a vSphere environment with region/zone tags on datastores
  • Verified controller no longer crashes and correctly skips datastore objects during host resolution

Release note:

Fixed a bug where the vSphere CSI controller would crashloop when topology tags (region/zone) were assigned to datastore objects in vCenter.

…tore

Signed-off-by: Sergey Petrov <sergey.petrov@flant.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 12, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: ptrvsrg / name: Sergey Petrov (dcb52f7)

@k8s-ci-robot
Copy link
Contributor

Welcome @ptrvsrg!

It looks like this is your first PR to kubernetes-sigs/vsphere-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/vsphere-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ptrvsrg
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @ptrvsrg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2026
@ptrvsrg ptrvsrg marked this pull request as ready for review March 12, 2026 07:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSI Controller CrashLoop when topology tags (region/zone) are assigned to a datastore

2 participants