Skip to content

Cleanup fake-attach FSS code#3917

Open
himanipatwa-wq wants to merge 2 commits intokubernetes-sigs:masterfrom
himanipatwa-wq:cleanup-fake-attach-fss
Open

Cleanup fake-attach FSS code#3917
himanipatwa-wq wants to merge 2 commits intokubernetes-sigs:masterfrom
himanipatwa-wq:cleanup-fake-attach-fss

Conversation

@himanipatwa-wq
Copy link
Contributor

@himanipatwa-wq himanipatwa-wq commented Mar 9, 2026

What this PR does / why we need it:
Removes fatke-attach FSS relate code
FSS used in VC 7.0U2

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

  1. wcp precheckin
    bn023052
    PR 3917

    Ran 16 of 2324 Specs
    SUCCESS! -- 16 Passed | 0 Failed | 0 Pending | 2308 Skipped | 0 Flaked

    VC ob-25274811
    ESX null
    VC IP 172.21.1.150

  2. vks precheckin
    bn023052
    PR 3917

    Ran 6 of 2324 Specs
    SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 2318 Skipped | 0 Flaked

    VC IP 172.21.1.150

Special notes for your reviewer:

Release note:

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: himanipatwa-wq
Once this PR has been reviewed and has the lgtm label, please assign gohilankit for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @himanipatwa-wq. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2026
@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #923

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1049

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1058

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #928

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #1058

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #928

Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove the flag in constants.go Line: 414

And no need to modify the below:

constants.go


AttributeFakeAttached = "fake-attach"

wcp/controller.go


publishInfo[common.AttributeFakeAttached] = "true"

You can undo the changes

@himanipatwa-wq himanipatwa-wq force-pushed the cleanup-fake-attach-fss branch from d0f9e34 to 8bc984f Compare March 19, 2026 22:26
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants