Fix Datacenter discovery failure after rename when MoRefs are used in the config secret#3891
Open
divyenpatel wants to merge 1 commit intokubernetes-sigs:masterfrom
Open
Conversation
When a Datacenter is renamed in vCenter, the CSI driver's syncer container can fail to discover or register nodes with errors like "datacenter '/path' not found", even if the configuration uses a MoRef. This happens because the core discovery logic was strictly path-based and would resolve MoRefs to paths, which then became stale after a rename. This commit updates the core VirtualCenter discovery logic to be explicitly MoRef-aware. It adds support for both the full MoRef format (e.g., Datacenter:datacenter-3) and the raw MoID format used in Supervisor clusters (e.g., datacenter-40). By anchoring the lookup to the immutable MoID, the driver remains resilient to Datacenter renames. Strict regex matching is used to distinguish between MoRefs and inventory paths to ensure that paths starting with "datacenter-" are still handled correctly by the path-based finder.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
divyenpatel
requested review from
chethanv28
and removed request for
akankshapanse and
kolluria
k8s-ci-robot
added
cncf-cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a Datacenter is renamed in vCenter, the CSI driver's syncer container can fail to discover or register nodes with errors like "datacenter '/path' not found", even if the configuration uses a MoRef. This happens because the core discovery logic was strictly path-based and would resolve MoRefs to paths, which then became stale after a rename.
This commit updates the core VirtualCenter discovery logic to be explicitly MoRef-aware. It adds support for both the full MoRef format (e.g., Datacenter:datacenter-3) and the raw MoID format used in Supervisor clusters (e.g., datacenter-40). By anchoring the lookup to the immutable MoID, the driver remains resilient to Datacenter renames.
Strict regex matching is used to distinguish between MoRefs and inventory paths to ensure that paths starting with "datacenter-" are still handled correctly by the path-based finder.
Testing done:
In progress
Special notes for your reviewer:
Release note: