Open
Conversation
for more information, see https://pre-commit.ci
Contributor
Author
|
I am sorry, I do not understand why coverage was not executed... any hints? |
Contributor
|
@franzhaas The CI broke completely a few days before you submitted this PR. If you rebase from main, it should pass this time. |
Contributor
Author
|
I tried, and it did mostly. I think the maintenance label would be apropriate... unfortunately I did not figure out how to select it... I think I am laking the rights to assign a label. Can you do that for me @shreve ? There is also an issue on macos, unfortunately I do not have access to a macos machine at the moment to look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reveal.js is currently at version 4.0.2, this is quite outdated.
This is an attempt to move reveal.js to the current 5.2.x releases.
This is an initial effort, but i expect more steps to be necessary. Lets see what CI finds and carry on from there.