Add docstring example for dynamic_batching decorator#6235
Open
veeceey wants to merge 1 commit intojina-ai:masterfrom
Open
Add docstring example for dynamic_batching decorator#6235veeceey wants to merge 1 commit intojina-ai:masterfrom
veeceey wants to merge 1 commit intojina-ai:masterfrom
Conversation
Previously, the dynamic_batching decorator docstring had a TODO to add an example. This commit adds a comprehensive example demonstrating how to use the decorator with an Executor to enable batching of incoming requests. The example shows: - Using @dynamic_batching with @requests decorator - Setting preferred_batch_size and timeout parameters - Processing batched DocumentArray in an async method
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@dynamic_batchingdecoratorChanges
@dynamic_batchingwith@requestsdecoratorpreferred_batch_sizeandtimeoutparametersTest plan