Skip to content

chore: add test assertion missing from #26691 #27276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gwossum wants to merge 1 commit into
base: master-1.x
Choose a base branch
from
+2 −0
Draft

chore: add test assertion missing from #26691 #27276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tsdb/engine/tsm1/array_cursor_optimization_bug_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ func TestAscendingCursorDuplicateDataBug(t *testing.T) {

// Verify no duplicates were found
assert.Equalf(len(seenTimestamps), len(allTimestamps), "Found duplicate timestamps! Total: %d, Unique: %d", len(allTimestamps), len(seenTimestamps))
// Confirm equal length of values and timestamps
assert.Equal(len(allValues), len(allTimestamps), "quantity of timestamps and values count mismatch: %d timestamps, %d values", len(allTimestamps), len(allValues))
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses assert.Equal with a format string and %d placeholders; Equal doesn’t apply formatting to msgAndArgs, so the failure message will be confusing. Use assert.Equalf (or build the message with fmt.Sprintf) and consider ordering the args as expected=len(allTimestamps), actual=len(allValues) to match the message text.

Suggested change
assert.Equal(len(allValues), len(allTimestamps), "quantity of timestamps and values count mismatch: %d timestamps, %d values", len(allTimestamps), len(allValues))
assert.Equalf(len(allTimestamps), len(allValues), "quantity of timestamps and values count mismatch: %d timestamps, %d values", len(allTimestamps), len(allValues))

Copilot uses AI. Check for mistakes.

// Verify we got all expected data (cache + TSM)
assert.Equalf(len(cacheValues)+len(tsmData[0].values), len(allTimestamps), "total timestamps")
Expand Down
Loading