Open
Conversation
Update the root package and website to Prettier 3 so formatting checks can parse the current configuration syntax consistently across the repository. Made-with: Cursor
Apply the new Prettier 3 output after the formatter upgrade so the repository matches the updated formatting rules and CI checks pass consistently. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to address the current CI failure that is affecting unrelated contribution PRs such as #437.
Summary
yarn ciby allowing formatting checks to parse the current config syntax correctlyWhy
For example, #437 is currently failing
yarn cionprettier --check ., even though the failure is not caused by the paste-related changes in that PR itself.Instead, the repository now includes syntax that the current Prettier 2.x setup cannot parse during CI, including:
satisfiesinwebsite/docusaurus.config.tswith { type: "json" }inrollup.config.mjsBecause
check-formatruns as part ofyarn ci, unrelated contribution PRs can fail before their actual changes are evaluated. Updating the formatter first should make those PRs easier to review on their own merits.Scope
Review notes
Upgrade Prettier to 3.8.1Reformat repository with Prettier 3