Fix iTerm2 configuration syntax error and add robust error handling

[Copilot]

Problem

The mac_setup.sh script was throwing a syntax error when configuring iTerm2 terminal themes:

/dev/fd/11: line 270: syntax error near unexpected token `>'

This error was likely caused by HTML entities (> instead of >) in the here-document block and lack of proper error handling for directory creation and file writing operations.

Solution

Enhanced the iTerm2 configuration block (lines 420-472) with comprehensive error handling and logging:

Key Improvements

1. Robust Directory Creation: Added error checking for mkdir -p with detailed logging
2. File Writing Verification: Wrapped the cat command with conditional error handling
3. Comprehensive Logging: Both success and failure cases are now logged to $LOG_FILE
4. Better Maintainability: Introduced ITERM_PROFILES_DIR variable for cleaner code
5. Missing Case Handling: Added proper warning when iTerm.app is not found
6. Script Integration: Errors properly set SETUP_SUCCESS=false for script-wide error handling

Before

mkdir -p "$HOME/Library/Application Support/iTerm2/DynamicProfiles"
cat > "$HOME/Library/Application Support/iTerm2/DynamicProfiles/Kali.json" << 'EOF'
# ... JSON content ...
EOF

After

ITERM_PROFILES_DIR="$HOME/Library/Application Support/iTerm2/DynamicProfiles"

# Ensure the directory exists with error handling
if ! mkdir -p "$ITERM_PROFILES_DIR" 2>/dev/null; then
  echo -e "${RED}❌ Failed to create iTerm2 profiles directory${NC}" | tee -a "$LOG_FILE"
  echo "ERROR: Could not create directory: $ITERM_PROFILES_DIR" >> "$LOG_FILE"
  SETUP_SUCCESS=false
else
  echo "✔ iTerm2 profiles directory created/verified: $ITERM_PROFILES_DIR" >> "$LOG_FILE"
  
  # Create the Kali theme configuration with error handling
  if cat > "$ITERM_PROFILES_DIR/Kali.json" << 'EOF'
  # ... JSON content ...
EOF
  then
    echo -e "${GREEN}✔ iTerm2 Kali theme configured${NC}"
    echo "✔ iTerm2 Kali theme created successfully" >> "$LOG_FILE"
  else
    echo -e "${RED}❌ Failed to create iTerm2 Kali theme${NC}" | tee -a "$LOG_FILE"
    echo "ERROR: Could not write to file: $ITERM_PROFILES_DIR/Kali.json" >> "$LOG_FILE"
    SETUP_SUCCESS=false
  fi
fi

Testing

• ✅ Script syntax validation passes (bash -n mac_setup.sh)
• ✅ Normal operation tested (with and without iTerm.app present)
• ✅ Error scenarios tested (permission failures, read-only directories)
• ✅ JSON structure validation confirms valid output
• ✅ Here-document formatting verified (no trailing spaces, proper EOF placement)

The iTerm2 configuration block now provides clear feedback on both success and failure scenarios, making the script more reliable and easier to troubleshoot.

This pull request was created as a result of the following prompt from Copilot chat.

The script mac_setup.sh throws a syntax error when configuring iTerm2 terminal themes:

/dev/fd/11: line 270: syntax error near unexpected token `>'

This is likely caused by the block:

cat > "$HOME/Library/Application Support/iTerm2/DynamicProfiles/Kali.json" << 'EOF'
...
EOF

To fix:

• Ensure the directory "$HOME/Library/Application Support/iTerm2/DynamicProfiles" exists before writing the file.
• Confirm the here-document is not indented, does not have trailing spaces after EOF, and is not commented out.
• Use mkdir -p to create the directory just before the cat command.
• Test the block independently to confirm it works in bash.
• Add error handling for directory creation and file writing.
• Optionally, log errors for troubleshooting.

Please update mac_setup.sh to fix this syntax error and ensure robust operation for the iTerm2 theme block.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.