Open
Conversation
Closed
|
@josegonzalez by any chance - can this be merged? If not could you please comment what need to be done to make it happen |
Contributor
|
@josegonzalez @mattatcha @nicofuccella Any chance of this being merged in soon? I'm not the author but I'd be happy to resolve conflicts (related to http_method addition I assume) and submit a separate PR. |
Member
|
Worth resubmitting.
|
Merged
Contributor
|
@nicofuccella see #672 which is a rebase of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add support for Consul gRPC check which was first introduced with Consul 1.0.5 release. The backends doc is also updated.