correctly handle uname-cmd that doesn't point to an executable file#2026
Merged
EliahKagan merged 16 commits intogitpython-developers:mainfrom May 28, 2025
Merged
correctly handle uname-cmd that doesn't point to an executable file#2026EliahKagan merged 16 commits intogitpython-developers:mainfrom
uname-cmd that doesn't point to an executable file#2026EliahKagan merged 16 commits intogitpython-developers:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also ran into the issue from #1979. My proposed solution is that
GitPythonshould only try to rununame_cmdif it points to an executable file. I also wrote a short test class for theis_cygwin_gitfunction. I don't have a machine with Cygwin, so I can't test that it actually does work, but I trust the Python docs when they say that on Cygwin,sys.platformwill becygwin.