Open
Conversation
JonasBa
commented
Mar 20, 2026
Comment on lines
-67
to
-76
| <Tooltip | ||
| title={dashboard.title} | ||
| position="top" | ||
| showOnlyOnOverflow | ||
| skipWrapper | ||
| > | ||
| <Text ellipsis variant="inherit"> | ||
| {dashboard.title} | ||
| </Text> | ||
| </Tooltip> |
Member
Author
There was a problem hiding this comment.
This was identical in the 3 places that use the reorderable links, so I built it into the component
… MDX MDX files are parsed by acorn which doesn't support TypeScript syntax. Removing the type annotations from the function signature fixes the lint and knip parse errors. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
Add explicit type annotations to MockPrimaryNav, ActivePrimaryLink, WithPageFrame, and MockSecondaryNav to resolve MDX typecheck errors. Co-Authored-By: Claude <noreply@anthropic.com>
Mirror the style pattern from SecondaryNavigationListItem by adding listStyleType: 'none' to prevent default bullet markers from appearing on reorderable list items rendered as <li> elements. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Add JSDoc type annotations to the four exported helper functions so that typecheck:mdx passes without implicit-any or type mismatch errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add stories for primary and secondary navigation so that we can have an overview of all the components in a single place + an easy way to toggle the page-frame view