Skip to content

ref(nav) cleanup stories#111231

Open
JonasBa wants to merge 10 commits intomasterfrom
jb/navigation/stories
Open

ref(nav) cleanup stories#111231
JonasBa wants to merge 10 commits intomasterfrom
jb/navigation/stories

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 20, 2026

Add stories for primary and secondary navigation so that we can have an overview of all the components in a single place + an easy way to toggle the page-frame view

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 20, 2026
Comment on lines -67 to -76
<Tooltip
title={dashboard.title}
position="top"
showOnlyOnOverflow
skipWrapper
>
<Text ellipsis variant="inherit">
{dashboard.title}
</Text>
</Tooltip>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was identical in the 3 places that use the reorderable links, so I built it into the component

… MDX

MDX files are parsed by acorn which doesn't support TypeScript syntax.
Removing the type annotations from the function signature fixes the
lint and knip parse errors.

Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
Add explicit type annotations to MockPrimaryNav, ActivePrimaryLink,
WithPageFrame, and MockSecondaryNav to resolve MDX typecheck errors.

Co-Authored-By: Claude <noreply@anthropic.com>
@JonasBa JonasBa marked this pull request as ready for review March 20, 2026 20:43
@JonasBa JonasBa requested a review from a team as a code owner March 20, 2026 20:43
Mirror the style pattern from SecondaryNavigationListItem by adding
listStyleType: 'none' to prevent default bullet markers from appearing
on reorderable list items rendered as <li> elements.

Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

JonasBa and others added 2 commits March 20, 2026 14:28
Add JSDoc type annotations to the four exported helper functions so
that typecheck:mdx passes without implicit-any or type mismatch errors.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants