Skip to content

[go_router_builder] Update route_config.dart to allow percent-encoding path#11291

Open
AlexeyBukin wants to merge 1 commit intoflutter:mainfrom
AlexeyBukin:patch-1
Open

[go_router_builder] Update route_config.dart to allow percent-encoding path#11291
AlexeyBukin wants to merge 1 commit intoflutter:mainfrom
AlexeyBukin:patch-1

Conversation

@AlexeyBukin
Copy link

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@AlexeyBukin AlexeyBukin requested a review from chunhtai as a code owner March 19, 2026 08:53
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added p: go_router_builder triage-framework Should be looked at in framework triage labels Mar 19, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to fix an issue with percent-encoding in path patterns by using Uri.encodeFull. While this works for spaces, it's an incomplete solution as it doesn't handle other characters that should be encoded in path segments (like +). I've suggested a more robust approach that correctly encodes all static path segments while leaving parameter placeholders untouched.

}),
);
final String location = patternToPath(_basePathForLocation, pathParameters);
final String location = patternToPath(Uri.encodeFull(_basePathForLocation), pathParameters);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using Uri.encodeFull is an improvement for paths with spaces, but it's not a complete solution. It doesn't encode other characters that should be percent-encoded in a path segment (like +), which can lead to malformed or ambiguous URLs.

A more robust approach is to split the path into segments, encode each static segment individually, and then rejoin them. This ensures that all special characters in static path segments are correctly encoded, while parameter placeholders are preserved for patternToPath.

Suggested change
final String location = patternToPath(Uri.encodeFull(_basePathForLocation), pathParameters);
final String location = patternToPath(_basePathForLocation.split('/').map((String s) => s.startsWith(':') ? s : Uri.encodeComponent(s)).join('/'), pathParameters);

@AlexeyBukin
Copy link
Author

AlexeyBukin commented Mar 19, 2026

Basically we Uri.encodeComponent every path parameter but the original url must be ascii. That's strange.
Let's say we have a path parameter id runtime resolving to пяты (id = 5 in belarussian).

@TypedGoRoute<ZoneRoute>(path: '/прывітанне/:id') // pass id = `пяты`
...

Resolving before pr: /прывітанне/%D0%BF%D1%8F%D1%82%D1%8B (Partly encoded?)

Resolving after pr: /%D0%BF%D1%80%D1%8B%D0%B2%D1%96%D1%82%D0%B0%D0%BD%D0%BD%D0%B5/%D0%BF%D1%8F%D1%82%D1%8B (Fully encoded!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: go_router_builder triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant