Merged
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix prepared fixes for all 3 issues found in the latest run.
- ✅ Fixed: Unused dependencies added to package.json
- Removed unused
react-markdownandremark-gfmfrom workshop-app dependencies and updated the lockfile.
- Removed unused
- ✅ Fixed: SVG in both image and text extension sets
- Removed
.svgfrom the text extension set so SVGs are consistently treated as images.
- Removed
- ✅ Fixed: Path traversal via query parameter in file-preview
- Added a resolved-path containment check so file previews only read files within the app roots.
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new "file" app type that renders a file explorer with rich file previews for apps without a
package.jsonorindex.*entry.This provides a default browsing experience for directories that don't conform to standard app structures, allowing users to explore their contents directly within the workshop environment. It includes specific rendering for common file types (code, markdown, image, video) and respects
.gitignorerules, while also excludingREADME.mdx.