Skip to content

Diff accordion sticky headers#583

Merged
kentcdodds merged 2 commits intomainfrom
cursor/diff-accordion-sticky-headers-3758
Mar 6, 2026
Merged

Diff accordion sticky headers#583
kentcdodds merged 2 commits intomainfrom
cursor/diff-accordion-sticky-headers-3758

Conversation

@kentcdodds
Copy link
Member

Make diff accordion headers sticky to keep them visible while scrolling file content.


Open in Web Open in Cursor 

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@cursor
Copy link
Contributor

cursor bot commented Mar 6, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@nx-cloud
Copy link

nx-cloud bot commented Mar 6, 2026

View your CI Pipeline Execution ↗ for commit 51f8f2b

Command Status Duration Result
nx run-many --target typecheck ✅ Succeeded 11s View ↗
nx run-many --target build ✅ Succeeded <1s View ↗
nx lint ✅ Succeeded 26s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-06 23:19:13 UTC

@kentcdodds kentcdodds marked this pull request as ready for review March 6, 2026 23:06
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

  • ✅ Fixed: Hover state makes sticky header nearly transparent
    • Updated the sticky header hover background to stay opaque so content no longer bleeds through.
  • ✅ Fixed: Double border when accordion items are collapsed
    • Removed the item-level border and moved the divider to the content so collapsed items only render a single border.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@kentcdodds kentcdodds merged commit f793a15 into main Mar 6, 2026
10 checks passed
kentcdodds added a commit that referenced this pull request Mar 6, 2026
* Make diff accordion headers sticky while scrolling

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

* Fix diff header hover and borders

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@kentcdodds kentcdodds deleted the cursor/diff-accordion-sticky-headers-3758 branch March 6, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants