Update some grpc, otel/sdk and some other go modules (v07)#3199
Update some grpc, otel/sdk and some other go modules (v07)#3199simonbaird wants to merge 4 commits intoconforma:release-v0.7from
Conversation
The last commit bumped it automatically to 1.25.0 in a couple of mod fules due to the module upgrade. Since we have 1.25.3 in other branches, I bumped it to 1.25.3.
Required to fix failing tests after last commit. It was something related to golang 1.25 tracing support in internal/downloader/downloader_test.go.
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoUpdate Go to 1.25.3 and upgrade gRPC, OpenTelemetry SDK, and dependencies
WalkthroughsDescription• Upgrade Go version from 1.24.6 to 1.25.3 across all modules • Update gRPC to v1.79.3 and related Envoy dependencies • Bump OpenTelemetry SDK and related packages to v1.42.0 • Update golang.org/x/exp and other stdlib packages to latest versions • Remove unused dependencies like github.com/zeebo/errs and github.com/gkampitakis/go-diff Diagramflowchart LR
A["Go 1.24.6"] -->|"Upgrade"| B["Go 1.25.3"]
B --> C["gRPC v1.79.3"]
B --> D["OpenTelemetry SDK v1.42.0"]
B --> E["Envoy v1.36.0"]
B --> F["stdlib packages updated"]
C --> G["Updated go.mod files"]
D --> G
E --> G
F --> G
File Changes3. acceptance/go.mod
|
Code Review by Qodo
1. Stale go-toolset digest
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| ## Build | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.24.6@sha256:6234f572204d672a0ee0686d748fbb9b7b05679368bf0d7a4446e13970e58060 AS build | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.25.3@sha256:6234f572204d672a0ee0686d748fbb9b7b05679368bf0d7a4446e13970e58060 AS build |
There was a problem hiding this comment.
1. Stale go-toolset digest 🐞 Bug ⛯ Reliability
Dockerfile.dist still pins the go-toolset image by the same sha256 digest while go.mod now requires Go 1.25.3, so dist/Konflux builds using Dockerfile.dist may still run an older toolchain and fail on the go.mod minimum Go version check.
Agent Prompt
### Issue description
`Dockerfile.dist` updates the go-toolset tag to `1.25.3` but the builder image is pinned by digest; with `go.mod` now requiring Go `1.25.3`, dist/Konflux builds may still use an older toolchain and fail to build.
### Issue Context
This repo’s dist builds and Tekton pipeline use `Dockerfile.dist`, so the builder image must actually provide a Go toolchain compatible with `go.mod`.
### Fix Focus Areas
- Dockerfile.dist[19-19]
- go.mod[1-5]
### Suggested change
Update `Dockerfile.dist` to use the correct digest for `registry.access.redhat.com/ubi9/go-toolset:1.25.3` (or remove the digest pin if pinning is not required by policy), ensuring the pinned image truly matches the intended Go toolset version.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Ref: https://redhat.atlassian.net/browse/EC-1721