Skip to content

Update some grpc, otel/sdk and some other go modules (v07)#3199

Open
simonbaird wants to merge 4 commits intoconforma:release-v0.7from
simonbaird:update-grpc-v07
Open

Update some grpc, otel/sdk and some other go modules (v07)#3199
simonbaird wants to merge 4 commits intoconforma:release-v0.7from
simonbaird:update-grpc-v07

Conversation

@simonbaird
Copy link
Member

The last commit bumped it automatically to 1.25.0 in a couple of mod
fules due to the module upgrade. Since we have 1.25.3 in other
branches, I bumped it to 1.25.3.
Required to fix failing tests after last commit. It was something
related to golang 1.25 tracing support in
internal/downloader/downloader_test.go.
@qodo-code-review
Copy link
Contributor

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Update Go to 1.25.3 and upgrade gRPC, OpenTelemetry SDK, and dependencies

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Upgrade Go version from 1.24.6 to 1.25.3 across all modules
• Update gRPC to v1.79.3 and related Envoy dependencies
• Bump OpenTelemetry SDK and related packages to v1.42.0
• Update golang.org/x/exp and other stdlib packages to latest versions
• Remove unused dependencies like github.com/zeebo/errs and github.com/gkampitakis/go-diff
Diagram
flowchart LR
  A["Go 1.24.6"] -->|"Upgrade"| B["Go 1.25.3"]
  B --> C["gRPC v1.79.3"]
  B --> D["OpenTelemetry SDK v1.42.0"]
  B --> E["Envoy v1.36.0"]
  B --> F["stdlib packages updated"]
  C --> G["Updated go.mod files"]
  D --> G
  E --> G
  F --> G
Loading

Grey Divider

File Changes

1. go.mod Dependencies +31/-33

Update Go version and module dependencies

go.mod


2. tools/go.mod Dependencies +29/-32

Update Go version and tool dependencies

tools/go.mod


3. acceptance/go.mod Dependencies +21/-24

Update Go version and acceptance test dependencies

acceptance/go.mod


View more (7)
4. tools/go.sum Dependencies +62/-78

Update checksums for all module dependencies

tools/go.sum


5. Dockerfile ⚙️ Configuration changes +1/-1

Update Go toolset image to 1.25.3

Dockerfile


6. Dockerfile.dist ⚙️ Configuration changes +1/-1

Update UBI Go toolset image to 1.25.3

Dockerfile.dist


7. tools/kubectl/go.mod Dependencies +1/-1

Update Go version to 1.25.3

tools/kubectl/go.mod


8. .tool-versions ⚙️ Configuration changes +1/-1

Update asdf Go version to 1.25.3

.tool-versions


9. acceptance/go.sum Additional files +132/-239

...

acceptance/go.sum


10. go.sum Additional files +110/-244

...

go.sum


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Mar 25, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Grey Divider


Action required

1. Stale go-toolset digest 🐞 Bug ⛯ Reliability
Description
Dockerfile.dist still pins the go-toolset image by the same sha256 digest while go.mod now requires
Go 1.25.3, so dist/Konflux builds using Dockerfile.dist may still run an older toolchain and fail on
the go.mod minimum Go version check.
Code

Dockerfile.dist[19]

+FROM registry.access.redhat.com/ubi9/go-toolset:1.25.3@sha256:6234f572204d672a0ee0686d748fbb9b7b05679368bf0d7a4446e13970e58060 AS build
Evidence
Dockerfile.dist pins the builder image by digest (so the digest is what determines the actual
toolchain), while the module’s required Go version is now 1.25.3. The repo’s dist build and Tekton
pipeline explicitly use Dockerfile.dist, so any mismatch affects CI/release builds.

Dockerfile.dist[19-19]
go.mod[3-3]
Makefile[63-72]
.tekton/cli-v07-pull-request.yaml[20-33]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`Dockerfile.dist` updates the go-toolset tag to `1.25.3` but the builder image is pinned by digest; with `go.mod` now requiring Go `1.25.3`, dist/Konflux builds may still use an older toolchain and fail to build.

### Issue Context
This repo’s dist builds and Tekton pipeline use `Dockerfile.dist`, so the builder image must actually provide a Go toolchain compatible with `go.mod`.

### Fix Focus Areas
- Dockerfile.dist[19-19]
- go.mod[1-5]

### Suggested change
Update `Dockerfile.dist` to use the correct digest for `registry.access.redhat.com/ubi9/go-toolset:1.25.3` (or remove the digest pin if pinning is not required by policy), ensuring the pinned image truly matches the intended Go toolset version.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 75953d9a-8675-4118-aa94-9ca17aa37637

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

## Build

FROM registry.access.redhat.com/ubi9/go-toolset:1.24.6@sha256:6234f572204d672a0ee0686d748fbb9b7b05679368bf0d7a4446e13970e58060 AS build
FROM registry.access.redhat.com/ubi9/go-toolset:1.25.3@sha256:6234f572204d672a0ee0686d748fbb9b7b05679368bf0d7a4446e13970e58060 AS build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Stale go-toolset digest 🐞 Bug ⛯ Reliability

Dockerfile.dist still pins the go-toolset image by the same sha256 digest while go.mod now requires
Go 1.25.3, so dist/Konflux builds using Dockerfile.dist may still run an older toolchain and fail on
the go.mod minimum Go version check.
Agent Prompt
### Issue description
`Dockerfile.dist` updates the go-toolset tag to `1.25.3` but the builder image is pinned by digest; with `go.mod` now requiring Go `1.25.3`, dist/Konflux builds may still use an older toolchain and fail to build.

### Issue Context
This repo’s dist builds and Tekton pipeline use `Dockerfile.dist`, so the builder image must actually provide a Go toolchain compatible with `go.mod`.

### Fix Focus Areas
- Dockerfile.dist[19-19]
- go.mod[1-5]

### Suggested change
Update `Dockerfile.dist` to use the correct digest for `registry.access.redhat.com/ubi9/go-toolset:1.25.3` (or remove the digest pin if pinning is not required by policy), ensuring the pinned image truly matches the intended Go toolset version.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
generative 69.55% <ø> (ø)
integration 69.55% <ø> (ø)
unit 69.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant