Fix test-service-broker crash on JDK 17 by adding --add-opens flags#1345
Open
jorbaum wants to merge 1 commit intocloudfoundry:5.x.xfrom
Open
Fix test-service-broker crash on JDK 17 by adding --add-opens flags#1345jorbaum wants to merge 1 commit intocloudfoundry:5.x.xfrom
jorbaum wants to merge 1 commit intocloudfoundry:5.x.xfrom
Conversation
Kehrlann
previously approved these changes
Mar 24, 2026
Contributor
Kehrlann
left a comment
Kehrlann
left a comment
There was a problem hiding this comment.
Thanks for the hotfix. Please target the 5.x.x branch. We'll forward port this.
The test-service-broker.jar (Spring Boot 1.5.16 / Spring Framework 4.3.19) uses CGLIB proxying which requires reflective access to java.lang.ClassLoader.defineClass(). JDK 17's module system blocks this, causing the app to crash on startup with InaccessibleObjectException and all ApplicationsTest methods to fail with DelayTimeoutException during serviceBrokerId bean creation.
jorbaum
force-pushed
the
buildpack-5-0-0-workaround
branch
from
ef0f69e to
8e2dd59
Compare
Author
|
I pushed the version that was rebased on 5.x.x . However, there is also test-log-cache.jar which might have similar issues. Even though I did not run into issues with it for the integration tests that I ran. Do you think the changes in this PR are fine without looking into / adding an additional workaround for test-log-cache.jar ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #1344 .
The test-service-broker.jar (Spring Boot 1.5.16 / Spring Framework 4.3.19) uses CGLIB proxying which requires reflective access to java.lang.ClassLoader.defineClass(). JDK 17's module system blocks this, causing the app to crash on startup with
InaccessibleObjectException and all ApplicationsTest methods to fail with DelayTimeoutException during serviceBrokerId bean creation.
Creating this as a draft as this is a workaround only to some parts of the integration tests work again.
AI tools used: Claude Code and GitHub Copilot (Opus 4.6) assisted me during development. I reviewed the result.