Fix for testing Vulkan on Linux & Windows#40
Open
jacksongoode wants to merge 3 commits intocjpais:mainfrom
Open
Fix for testing Vulkan on Linux & Windows#40jacksongoode wants to merge 3 commits intocjpais:mainfrom
jacksongoode wants to merge 3 commits intocjpais:mainfrom
Conversation
Closed
Owner
|
Im rewriting everything so sorry, I am ripping what was merged out, so this probably will need a rewrite too |
Contributor
Author
|
No worries, we can fix the tests after. |
Owner
|
I think the right fix here is to disable Vulkan or be able to disable Vulkan so we can at least run CPU tests potentially I'm probably gonna push this change in either today or tomorrow |
Contributor
Author
Okay that sounds fine, I can make the change or you, just make sure we're green before we merge :) |
Owner
|
Please feel free to :) I'm deep in 100 issues right now but would love to get testing working in ci here too Tiny for whisper is surely fine :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to #39
Please have a look through this one, tests should pass but a few changes:
I'm not really sure about the GPU stuff, I don't think the Windows or Linux runners have GPUs?
After this it would be good to rebase #27 and #37 to get testing on their package bumps.