Skip to content

AbstractOpenPGPDocumentSignatureGenerator: Properly apply signature c…#2261

Open
vanitasvitae wants to merge 2 commits intobcgit:mainfrom
pgpainless:applySignatureCreationTime
Open

AbstractOpenPGPDocumentSignatureGenerator: Properly apply signature c…#2261
vanitasvitae wants to merge 2 commits intobcgit:mainfrom
pgpainless:applySignatureCreationTime

Conversation

@vanitasvitae
Copy link
Contributor

…reation time from SignatureParameters

This fixes OpenPGPMessageGenerator not applying custom signature creation times for message signatures.

        // Generate message at t1
        OpenPGPMessageGenerator mGen = api.signAndOrEncryptMessage()
                .addSigningKey(key, new SignatureParameters.Callback() {
                    @Override
                    public SignatureParameters apply(SignatureParameters parameters) {
                        return parameters.setSignatureCreationTime(t1); // this call was ignored, but is fixed with the patch.
                    }
                });

…reation time from SignatureParameters

This fixes OpenPGPMessageGenerator not applying custom signature creation times for message signatures
@ligefeiBouncycastle ligefeiBouncycastle self-requested a review March 24, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant