Skip to content

chore: Send Booleans as true or false to API#673

Open
Pijukatel wants to merge 2 commits intomasterfrom
send-booleans
Open

chore: Send Booleans as true or false to API#673
Pijukatel wants to merge 2 commits intomasterfrom
send-booleans

Conversation

@Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Mar 16, 2026

Sending 1 and 0 is working, but the validator is complaining about that.
Lets align with the JS client. JS client uses false, true
OpenAPI spec does not define serialization of Booleans, but tools frequently choose false/true

Issues:

Related to: apify/apify-docs#2286

(sending 1 and 0 is working, but undocumented. Spec defines booleans, JS client as well)
@github-actions github-actions bot added this to the 136th sprint - Tooling team milestone Mar 16, 2026
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.75%. Comparing base (5b57ff3) to head (c401f2e).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files          45       45           
  Lines        4404     4404           
=======================================
  Hits         4173     4173           
  Misses        231      231           
Flag Coverage Δ
integration 94.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a fix? Also, there are tests failing.

@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Mar 23, 2026
@Pijukatel
Copy link
Contributor Author

Isn't this a fix? Also, there are tests failing.

It is not a fix. Both are working and since the specification does not define which is the correct one it is just an implementation detail.

It is convenient to be aligned in both clients though.

@Pijukatel Pijukatel requested a review from vdusek March 23, 2026 10:54
@Pijukatel
Copy link
Contributor Author

Btw. I will anyway silence any warning related to this in the validator, something like this
https://github.com/apify/apify-core/commit/e525476d9597fda734b843365134d86e65841075

(So "0","1","true", "false" will be still all valid options for the validator)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants