chore: Send Booleans as true or false to API#673
Conversation
(sending 1 and 0 is working, but undocumented. Spec defines booleans, JS client as well)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 45 45
Lines 4404 4404
=======================================
Hits 4173 4173
Misses 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
left a comment
There was a problem hiding this comment.
Isn't this a fix? Also, there are tests failing.
It is not a fix. Both are working and since the specification does not define which is the correct one it is just an implementation detail. It is convenient to be aligned in both clients though. |
|
Btw. I will anyway silence any warning related to this in the validator, something like this (So "0","1","true", "false" will be still all valid options for the validator) |
Sending
1and0is working, but the validator is complaining about that.Lets align with the JS client. JS client uses
false,trueOpenAPI spec does not define serialization of Booleans, but tools frequently choose
false/trueIssues:
Related to: apify/apify-docs#2286