SOLR-13309: Add DoubleRangeField exposing Lucene 'DoubleRange'#4239
Open
gerlowskija wants to merge 1 commit intoapache:mainfrom
Open
SOLR-13309: Add DoubleRangeField exposing Lucene 'DoubleRange'#4239gerlowskija wants to merge 1 commit intoapache:mainfrom
gerlowskija wants to merge 1 commit intoapache:mainfrom
Conversation
Mirrors recently added 'IntRangeField', 'LongRangeField', and 'FloatRangeField' types, and completes our coverage for Lucene's "range" field types.
Contributor
Author
|
In self-reviewing, I got a ton of mileage out of using e.g. Feel free to ignore, but I found it helpful 🤷 |
Contributor
Author
|
Leaving a note to myself here that tests and check both pass locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-13309
Description
We have made changes recently to expose Lucene's
IntRange,LongRange, andFloatRangefield, but Solr still lacks coverage forDoubleRange.This PR adds the
DoubleRangeFieldfield type to exposeDoubleRange. When merged, we'll have support for all of Lucene's "numeric range" field offerings!Solution
This PR takes a nearly identical approach to that seen recently in #4229, which introduced
FloatRangeField. The primary differences is that this PR uses 'double'/'Double' instead of 'float'/'Float', and that this PR is actually a good deal simpler as it's able to rely on groundwork already laid in the previous #4229.For those without context on 4229, the overview is that:
Since this PR is so substantially similar to #4229, I was able to use Claude code to generate the tests and DoubleRangeField class.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.