Skip to content

test: update sqllogictest expectation for negation type coercion#21102

Open
myandpr wants to merge 1 commit intoapache:mainfrom
myandpr:slt-negation-type-coercion
Open

test: update sqllogictest expectation for negation type coercion#21102
myandpr wants to merge 1 commit intoapache:mainfrom
myandpr:slt-negation-type-coercion

Conversation

@myandpr
Copy link
Contributor

@myandpr myandpr commented Mar 22, 2026

Which issue does this PR close?

link: https://github.com/apache/datafusion/actions/runs/23406116823/job/68085237860

Rationale for this change

#20965 moved invalid negation validation into the analyzer/type coercion path.

After that change, the SELECT -'100' sqllogictest case now reports the error through type_coercion, but scalar.slt was still expecting the older error form. This follow-up updates the sqllogictest expectation to match the current behavior.

What changes are included in this PR?

Are these changes tested?

Yes.

I reproduced the failure locally and verified the updated expectation with:

  • cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar

Are there any user-facing changes?

No.

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Mar 22, 2026
@myandpr
Copy link
Contributor Author

myandpr commented Mar 22, 2026

Hey @alamb This is the follow-up PR for the sqllogictest expectation mismatch as discussed in #20965 (#20965 (comment)). I reproduced the failure locally on the latest main and updated scalar.slt to match the current type_coercion error shape.

Could you please take a look when you have a chance? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant