Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 33 commits into
base: main
Choose a base branch
from

fix creation of volume on destination host during migration to clvm/c…

7e5e1e7
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

fix creation of volume on destination host during migration to clvm/c…
7e5e1e7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 23, 2026 in 5m 54s

Quality Gate failed

Failed conditions
1 Security Hotspot
8.5% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 41 in server/src/main/java/com/cloud/storage/ClvmLockManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTXm331ZRqy8rtiu&open=AZycJTXm331ZRqy8rtiu&pullRequest=12617

Check warning on line 979 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Introduce a new variable instead of reusing the parameter "lvDevice". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrP&open=AZz35YeN4256DVCsFLrP&pullRequest=12617

Check failure on line 1552 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "qemu-img" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrV&open=AZz35YeN4256DVCsFLrV&pullRequest=12617

Check warning on line 2396 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxOatxGxHcHLzahJAAI&open=AZxOatxGxHcHLzahJAAI&pullRequest=12617

Check warning on line 813 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrN&open=AZz35YeN4256DVCsFLrN&pullRequest=12617

Check warning on line 431 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrZ&open=AZz35YeN4256DVCsFLrZ&pullRequest=12617

Check warning on line 945 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvmD&open=AZxEJ4RLTdhpX5MPbvmD&pullRequest=12617

Check failure on line 2596 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZ5Qi8wmAtCWzk9s&open=AZxykZ5Qi8wmAtCWzk9s&pullRequest=12617

Check warning on line 694 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTGW331ZRqy8rtie&open=AZycJTGW331ZRqy8rtie&pullRequest=12617

Check warning on line 502 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 119 to 64, Complexity from 23 to 14, Nesting Level from 3 to 2, Number of Variables from 42 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJS_0331ZRqy8rtiZ&open=AZycJS_0331ZRqy8rtiZ&pullRequest=12617

Check failure on line 2961 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZ5Qi8wmAtCWzk9u&open=AZxykZ5Qi8wmAtCWzk9u&pullRequest=12617

Check warning on line 7189 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "details" which hides the field declared at line 260. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZyLLxjoyspAfen4iU0T&open=AZyLLxjoyspAfen4iU0T&pullRequest=12617

Check failure on line 275 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZmDi8wmAtCWzk9i&open=AZxykZmDi8wmAtCWzk9i&pullRequest=12617

Check warning on line 2427 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxOatxGxHcHLzahJAAJ&open=AZxOatxGxHcHLzahJAAJ&pullRequest=12617

Check warning on line 3258 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YY_4256DVCsFLrG&open=AZz35YY_4256DVCsFLrG&pullRequest=12617

Check failure on line 2609 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "lvcreate" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0H7qRYrpT77nGx4twT&open=AZ0H7qRYrpT77nGx4twT&pullRequest=12617

Check warning on line 373 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTTp331ZRqy8rtij&open=AZycJTTp331ZRqy8rtij&pullRequest=12617

Check warning on line 420 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrL&open=AZz35YeN4256DVCsFLrL&pullRequest=12617

Check failure on line 2141 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "null answer returned" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz4pqxYEjiWGn0xPnaU&open=AZz4pqxYEjiWGn0xPnaU&pullRequest=12617

Check warning on line 281 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_agentMgr" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJS_0331ZRqy8rtiV&open=AZycJS_0331ZRqy8rtiV&pullRequest=12617

Check failure on line 6650 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 24 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxtJVnqJejGTVrNgEqE&open=AZxtJVnqJejGTVrNgEqE&pullRequest=12617

Check failure on line 1554 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--output=json" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrS&open=AZz35YeN4256DVCsFLrS&pullRequest=12617

Check warning on line 958 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvmE&open=AZxEJ4RLTdhpX5MPbvmE&pullRequest=12617

Check warning on line 86 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_volDetailsDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZx43iV5jVPAID_RF5bq&open=AZx43iV5jVPAID_RF5bq&pullRequest=12617

Check warning on line 1630 in server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 89 to 64, Complexity from 20 to 14, Nesting Level from 4 to 2, Number of Variables from 21 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTRR331ZRqy8rtii&open=AZycJTRR331ZRqy8rtii&pullRequest=12617
View more details on SonarQubeCloud