Fix assertion if index is dropped during REFRESH CONCURRENTLY#1632
Open
reshke wants to merge 3 commits intoapache:mainfrom
Open
Fix assertion if index is dropped during REFRESH CONCURRENTLY#1632reshke wants to merge 3 commits intoapache:mainfrom
reshke wants to merge 3 commits intoapache:mainfrom
Conversation
This commit changes libpq so that errors reported by the backend during the protocol negotiation for SSL and GSS are discarded by the client, as these may include bytes that could be consumed by the client and write arbitrary bytes to a client's terminal. A failure with the SSL negotiation now leads to an error immediately reported, without a retry on any other methods allowed, like a fallback to a plaintext connection. A failure with GSS discards the error message received, and we allow a fallback as it may be possible that the error is caused by a connection attempt with a pre-11 server, GSS encryption having been introduced in v12. This was a problem only with v17 and newer versions; older versions discard the error message already in this case, assuming a failure caused by a lack of support for GSS encryption. Author: Jacob Champion Reviewed-by: Peter Eisentraut, Heikki Linnakangas, Michael Paquier Security: CVE-2024-10977 Backpatch-through: 12
x4m
approved these changes
Mar 21, 2026
avamingli
approved these changes
Mar 23, 2026
Contributor
avamingli
left a comment
avamingli
left a comment
There was a problem hiding this comment.
Thanks for cherry-pick.
When assertions are disabled, the built SQL statement is invalid and you get a "syntax error". So this isn't a serious problem, but let's avoid the assertion failure. Backpatch to all supported versions. Reviewed-by: Noah Misch
reshke
force-pushed
the
cp_a45c950ae35e53de40_main
branch
from
a164d84 to
fb20573
Compare
reshke
force-pushed
the
cp_a45c950ae35e53de40_main
branch
from
fb20573 to
f893f35
Compare
Contributor
|
matview tests failed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When assertions are disabled, the built SQL statement is invalid and you get a "syntax error". So this isn't a serious problem, but let's avoid the assertion failure.
Backpatch to all supported versions.
Reviewed-by: Noah Misch
======
In CBDB, we backport this change for future-proofing and in sight of d42418a and general backporting of all security-related changes.