Filled missing descriptions for all entities & minor tweaks.#308
Merged
TeamSpen210 merged 15 commits intoStrataSource:masterfrom Mar 22, 2026
Merged
Filled missing descriptions for all entities & minor tweaks.#308TeamSpen210 merged 15 commits intoStrataSource:masterfrom
TeamSpen210 merged 15 commits intoStrataSource:masterfrom
Conversation
As the summary implies. Some existing descriptions have been updated as well. The main reason behind this is the wiki - it uses the missing description values (i.e. spawnflags) and therefore looks bad. But more importantly, this adds more convinience in using entities, especially with the new descriptions.
Added more descriptions, moved `projected_tractor_beam_entity` into the fgd, added transparent nodraw.
Added Non-FGD visgroup.
This reverts commit dd36ff7.
This reverts commit f44a7ce.
Author
|
The last 5 commits are purely to make it easier to review the PR. Unfortunately, some spawnflags have "spawnflags" and some don't, so I can't revert those keyvalues in any other way than manually |
TeamSpen210
requested changes
Mar 20, 2026
Member
TeamSpen210
left a comment
TeamSpen210
left a comment
There was a problem hiding this comment.
Looks good in general, though some descriptions just restate what the KV name says. Oh well. You/I will need to re-apply this upstream, I'm aiming to hopefully switch Strata to use the base repo so there isn't two copies of everything.
TeamSpen210
previously approved these changes
Mar 22, 2026
| @PointClass base(BaseEntityPoint) | ||
| appliesto(+engine, P2CE) | ||
| appliesto(P2CE) | ||
| = projected_tractor_beam_entity: "The actual Excursion Funnel itself, projected from prop_tractor_beam." |
Member
There was a problem hiding this comment.
I don't think this should be exposed publicly still, it doesn't need to be in the FGD.
fgd/brush/momentary_rot_button.fgd
Outdated
|
|
||
| sounds[engine](integer) : "Sounds" : 0 | ||
| sounds(choices) : "Sounds" : 0 : "Sound played when pressed. Choose from sounds in the Buttons.snd* category." = | ||
| sounds(choices) : "Sounds" : 0 : "Sound played when pressed." = |
Member
There was a problem hiding this comment.
Suggested change
| sounds(choices) : "Sounds" : 0 : "Sound played when pressed." = | |
| sounds(choices) : "Sounds" : 0 : "Sound played when pressed. This plays 'Buttons.sndXX', where XX is the provided number." = |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: