Add XD Encounters, Encounter Conditions, Locations, Location Areas, Encounter Methods, and a few more things#1446
Open
notblisy wants to merge 1 commit intoPokeAPI:masterfrom
Open
Conversation
Contributor
Author
|
I think that for encounter condition value map I might have put the wrong value? Is 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add all the encounter locations, conditions, and items for Pokemon obtainable in Pokemon XD: Gale of Darkness.
This is a fair bit larger than Pokemon Colosseum, as there's 82 Shadow Pokemon in this game, plus a few extra gift Pokemon.
I sourced my data from:
https://bulbapedia.bulbagarden.net/wiki/List_of_Shadow_Pok%C3%A9mon#List_of_Shadow_Pok%C3%A9mon_in_Pok%C3%A9mon_XD:_Gale_of_Darkness for shadows
https://bulbapedia.bulbagarden.net/wiki/Gateon_Port#Trainers for dragonites condition, at the bottom with mirror b
https://bulbapedia.bulbagarden.net/wiki/Duking for trades
https://bulbapedia.bulbagarden.net/wiki/Gift_Pok%C3%A9mon#XD:_Gale_of_Darkness - for the gift Pokemon
For the encounters, I added the usual:
In addition to all the relevant prose for these.
On top of that, I've added a new encounter method:
This is a unique way to catch wild Pokemon in XD, where you leave a snack out for a Pokemon, and one of 3 different Pokemon can come to eat it. Then you get to do a wild battle and capture.
During my time modeling XD, I noticed that while there IS an NPC-Trade option in encounter_methods.csv, this doesn't allow us to note WHICH Pokemon the player would have to trade. So, I added a new encounter condition called:
Then, in encounter_condition_values.csv I would describe both the NPCs name and Pokemon to trade them.
An example is that for a larvitar, duking wants a wooper. So I have the encounter condition value id set to:
Encounter conditions seem to be rarely used so far in the API, but I think they are a great way to add specificity to encounters like trades or gifts outside of just locations. I hope this was okay to add!