Remove workaround related to LongPathsEnabled on Windows#1826
Draft
rwgk wants to merge 3 commits intoNVIDIA:mainfrom
Draft
Remove workaround related to LongPathsEnabled on Windows#1826rwgk wants to merge 3 commits intoNVIDIA:mainfrom
LongPathsEnabled on Windows#1826rwgk wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
The CI runners now have LongPathsEnabled=1 (nv-gha-runners/vm-images#241), so remove the skip of pip install and all_must_work tests for py3.14t on Windows. Add a fail-early step to catch runners that lack the setting. Closes NVIDIA#1820 Made-with: Cursor
rwgk
added
CI/CD
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
Disable Linux builds/tests and docs, filter Windows test matrix to py3.14t to verify LongPathsEnabled fix in isolation. Revert before merge. Made-with: Cursor
rwgk
force-pushed
the
make_use_of_LongPathsEnabled
branch
from
14a496b to
a92790a
Compare
Collaborator
Author
|
/ok to test |
This reverts commit a92790a.
Collaborator
Author
|
/ok to test |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1820
The CI runner images now have
LongPathsEnabled=1(nv-gha-runners/vm-images#241), so thenvidia-cutlasswheel installs successfully under free-threaded Python on Windows even though the longest path (266 characters) exceeds the default MAX_PATH limit.Changes
if: !endsWith(matrix.PY_VER, 't')guards that skippedpip install --groupand theall_must_workpathfinder test for free-threaded Python on WindowsVerify LongPathsEnabledstep that fails early with a clear error referencing [BUG]: Windows CI runners need LongPathsEnabled for free-threaded Python #1820 if a runner lacks the registry setting