askrene: deprecate auto.no_mpp_support layer in favor of maxparts=1#8980
Open
vincenzopalazzo wants to merge 1 commit intoElementsProject:masterfrom
Open
askrene: deprecate auto.no_mpp_support layer in favor of maxparts=1#8980vincenzopalazzo wants to merge 1 commit intoElementsProject:masterfrom
vincenzopalazzo wants to merge 1 commit intoElementsProject:masterfrom
Conversation
vincenzopalazzo
force-pushed
the
deprecate-auto-no-mpp-support
branch
from
fbc8d7f to
a6a6eb9
Compare
Now that getroutes has a maxparts parameter, the auto.no_mpp_support magic layer is no longer needed. Setting maxparts=1 achieves the same single-path routing behavior. - Deprecate auto.no_mpp_support in param_layer_names (v25.09 -> v26.08) - Update xpay to use maxparts=1 instead of auto.no_mpp_support layer - Update tests to use maxparts=1 - Update documentation to note the deprecation Fixes ElementsProject#8871 Changelog-Deprecated: JSON-RPC: `getroutes` `auto.no_mpp_support` layer: use `maxparts=1` instead.
vincenzopalazzo
force-pushed
the
deprecate-auto-no-mpp-support
branch
from
a6a6eb9 to
b40f743
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto.no_mpp_supportmagic layer in askrene'sgetroutesusingcommand_deprecated_in_ok(v25.09 -> v26.08)maxparts=1instead of adding theauto.no_mpp_supportlayer when MPP is disabledmaxparts=1instead of the deprecated layerNow that
getrouteshas amaxpartsparameter, callers can simply setmaxparts=1to force single-path routing instead of using the magic layer name.Fixes #8871
Test plan
test_getroutes_single_pathpasses withmaxparts=1test_excessive_fee_costpasses withmaxparts=1test_impossible_paymentpasses withmaxparts=1maxparts=1